Repository navigation
Conversation
hsoliwal
marked this pull request as ready for review
October 21, 2026 01:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive superset / review scope
Builds on the unchanged source head of Platform UI PR #22 (
71bec8695fe39aac69e63f8cf306237a91f8b33f) and targets its parent branchm3/jface-viewport-20261019. The original preservation PR, parent JFace implementation, all source trees and pre-existing artifacts remain untouched.Mechanical behavior repair
rm -rfdeleting their old evidence.Actual verification
Local
bash -non both scripts PASS.bash run_ab_safety_test.sh run_ab.shPASS, covering two modes/two repetitions, existing snapshot/output preservation, invalid tag/path, invalid scenario range and filesystem-root refusal.The committed production helper and regression script Git blobs matched the locally tested source bytes at
956564a4c888b15344f0fbc1154be61d72840e3band7ecdf25775e099df5488925162b2001e3a9a4bfc.Gates explicitly NOT claimed
The Windows/Cygwin desktop lock and real JFace SWT/Markers benchmark are not executed here. Parent PR #21 still requires stock-vs-viewport differential proof and whole-product checks. This is a reversible test-safety repair, not viewport runtime admission; keep draft until those gates qualify.
No squash/rebase/force-push; no modifications to any preservation branch.