Skip to content

fix(viewer): preserve A/B snapshots and reject destructive reruns - #23

Merged
hsoliwal merged 4 commits into
m3/jface-viewport-20261019from
fix/m3-viewport-ab-snapshot-safety-20261020
Oct 21, 2026
Merged

hsoliwal merged 4 commits into
m3/jface-viewport-20261019from
fix/m3-viewport-ab-snapshot-safety-20261020

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Additive superset / review scope

Builds on the unchanged source head of Platform UI PR #22 (71bec8695fe39aac69e63f8cf306237a91f8b33f) and targets its parent branch m3/jface-viewport-20261019. The original preservation PR, parent JFace implementation, all source trees and pre-existing artifacts remain untouched.

Mechanical behavior repair

  • Retain the same original/viewport A/B labels, execution order, frozen class inputs and desktop-lock/hidden-JVM paths.
  • Refuse existing snapshot/run IDs rather than rm -rf deleting their old evidence.
  • Validate benchmark tag, numeric bounds, output root and run directory before creating a run.
  • Create isolated snapshots and per-mode folders without overwriting existing outputs; reject symlinked runs root.
  • Preserve dual SPDX source header and the gate table carried from PR chore(ui): preserve viewport gates and A/B helper #22.
  • Add a hermetic Bash regression script with mock environment and mock benchmark, with no Eclipse GUI, runtime or network dependency.

Actual verification

Local bash -n on both scripts PASS. bash run_ab_safety_test.sh run_ab.sh PASS, covering two modes/two repetitions, existing snapshot/output preservation, invalid tag/path, invalid scenario range and filesystem-root refusal.
The committed production helper and regression script Git blobs matched the locally tested source bytes at 956564a4c888b15344f0fbc1154be61d72840e3b and 7ecdf25775e099df5488925162b2001e3a9a4bfc.

Gates explicitly NOT claimed

The Windows/Cygwin desktop lock and real JFace SWT/Markers benchmark are not executed here. Parent PR #21 still requires stock-vs-viewport differential proof and whole-product checks. This is a reversible test-safety repair, not viewport runtime admission; keep draft until those gates qualify.

No squash/rebase/force-push; no modifications to any preservation branch.

@hsoliwal
hsoliwal marked this pull request as ready for review October 21, 2026 01:12
@hsoliwal
hsoliwal merged commit e6d4268 into m3/jface-viewport-20261019 Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant