Repository navigation
Refine Eclipse M3 slot ranks and JFace source ranges - #26
Merged
Merged
Conversation
Preserve array payloads, comparator and UTF-16 contracts through qualified Synexia recipes. Repair owning test placement and dead cache fields; ship pinned donor notices with the actual bundle. Validation: 35 final SDK tests, 35 selected offline Tycho tests, independent Java 21/25 differentials, and exact binary/source attribution checks. Full UI/native and complete M3JDK21 image gates remain open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is needed
The M3 marker implementation merged in #21 already stores rows in blocked primitive arrays.
M3SlotOrder.getand rank lookup still scan preceding block lengths, while JFace mnemonic removal creates temporary substrings solely to append them to a builder.This PR refines those actual Eclipse owners through the canonical Synexia recipes, retaining the existing APIs and observed contracts.
Changes
M3SlotOrder. Prefix sums, point updates and cumulative selection reuse pinned Synexia/SWT Fenwick implementations. Directories of at most eight blocks retain the measured cheaper scan.fillinvalidates derived counts and retains the original scan behavior.LegacyActionTools.removeMnemonicsto source ranges. UTF-16 scanning, escaped/trailing ampersands, DBCS behavior and reference relationships remain unchanged.M3MarkerCategoryfields and their dead write, fixing the owning compiler errors. Keep its no-opclearCache()override so it does not inherit child traversal.M3IndexTesttests byte-for-byte into a Java 21 JFace host fragment and add seven mnemonic regression tests. No production exports are added.Qualification
-amThe selected Tycho tests have zero failures, errors or skips. Builds use Maven 3.9.12 and fixed SDK
I20261018-2300; missing-artifact attempts and bounded dependency bootstrap are retained, followed by successful offlineclean verifyruns. The final source index matches all fifteen paths, the old test is absent, and all 573 earlier JFace inputs plus 2,250 final marker inputs remain unchanged.The licensed
M3SlotOrdersource is SHA-256e43165029073da1da0501210f450711d81d4d0f7685de349413899d4a39a685d. Its 9,579 bytes from the package declaration onward exactly match the behaviorally qualifiedfd75ecf5…candidate. The final source also passes Java 21 all-lint compilation with warnings as errors.Measured tradeoffs
These are finite standalone JDK 21 measurements, not UI latency or complete M3JDK21 runtime results:
Recipe ownership and runtime connection
Canonical recipes, donor pins, category catalogue, selection/rejection rationale, exact fixtures, raw logs and replay instructions: com.synexia #12665.
The existing M3JDK21 String owner receives the public range-append API under its own admission conditions. The JFace pass reuses that API without copying JDK implementation bodies. Related Java collection/JNI work is M3JDK21 #1619, with prerequisite #1618. This Eclipse pass introduces no additional JNI symbol.
Scope and remaining gates
Draft for review. The current ui.ide reactor requires Java 25; the actual Eclipse Tycho build/test runtime was JDK 25, although JFace and its fragment emit Java 21 classes. The recipe SDK gate uses JDK 21. This does not qualify the full current IDE on M3JDK21.
Full UI/native smoke execution, a complete source-built M3JDK21 image, repository-wide dependency source closure, and the remaining marked-source census are separate gates. The catalogue records the existing resource-scoped marker-identity issue and rejects map/mask substitutions that change observable key or alias behavior. Those issues are not claimed fixed here.
Receiving base:
10da6ccd9b8c109a2e507a4fbc7afdc7f53eb264. It has exactly the same tree as the originally frozen #21 head.