Repository navigation
tools/jtag: libftdi from $T27_LIBFTDI or the platform default, so B2 reads on Linux (Closes #7927) - #8842
Open
dmitrii-f-t27 wants to merge 2 commits into
Open
tools/jtag: libftdi from $T27_LIBFTDI or the platform default, so B2 reads on Linux (Closes #7927)#8842dmitrii-f-t27 wants to merge 2 commits into
dmitrii-f-t27 wants to merge 2 commits into
Conversation
…reads on Linux (Closes gHashTag#7927) mpsse_jtag.py loaded libftdi from the fixed Homebrew path, so stage B2 of t27c silicon (read_verdict.py) failed on Linux without a symlink (gHashTag#7906). LIB is now $T27_LIBFTDI when set; else /opt/homebrew/lib/libftdi1.2.dylib on macOS (unchanged); else ctypes.util.find_library("ftdi1") or libftdi1.so.2. 3 lines in, 3 lines out: the file is listed in tools/policy/foreign-exceptions.txt (gHashTag#7928) and foreign code does not grow. Closes gHashTag#7927
Contributor
Author
|
Updated 2026-10-11. Head The required contexts ( Three checks are red. Each one fails the same way on master:
The earlier reds on head Nothing to fix in this PR. These failures come from master. Dmitrii Fedorov (@dmitrii-f-t27) |
This was referenced Oct 10, 2026
This was referenced Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7927
Description
tools/jtag/mpsse_jtag.pyloaded libftdi from a fixed Homebrew path, so stage B2 oft27c silicon(read_verdict.py) failed on Linux withOSError: /opt/homebrew/lib/libftdi1.2.dylib: cannot open shared object file. Die C of R3-3 passed only with a symlink at that path inside the container (#7906, "Caveats").This is step 2 of #7927. Step 1 was #7928 (merged): the owner-approved exception for this file in
tools/policy/foreign-exceptions.txt.Changes
tools/jtag/mpsse_jtag.py, 3 lines in, 3 lines out:check_budget, owner rule 2026-10-09) does not allow a foreign file to grow.No
.t27for this change. There is no Python back end, so no spec can generate this file. The portspecs/port/tools/jtag/mpsse_jtag.t27is a stub. The route is the owner-approved exception from #7928. No spec, seal or conformance vector changes.Testing
On the head commit (macOS 26, Python 3.14.3, libftdi 1.5_2 from Homebrew):
gen/c/policy/own_language.c,--ci, exceptions read from the base): exit 0.check_budgetfrom the base): exit 0 (3 3 tools/jtag/mpsse_jtag.py).python3 -c "import sys; sys.path.insert(0,'tools/jtag'); import mpsse_jtag": exit 0,LIB = /opt/homebrew/lib/libftdi1.2.dylib, the same as on master.T27_LIBFTDI=/opt/homebrew/Cellar/libftdi/1.5_2/lib/libftdi1.2.dylib: the module loads that exact path.T27_LIBFTDI=/nonexistent/...:OSErrorthat names the given path, so a bad override is reported, not hidden.py_compileonmpsse_jtag.py,read_verdict.py,read_user1.py,link_relay.py: OK.ctypes.CDLLstubbed (sys.platform,T27_LIBFTDIandfind_libraryvaried over 8 cases: darwin, linux, env set, env empty,find_libraryNone): 8/8 PASS on this branch. Negative control on master's file: 2/8 (only the two darwin defaults pass).Not verified
t27c siliconB2 on a Linux host with a board.Review Notes
tools/policy/foreign-exceptions.txt:449still says "owner approval pending". That is out of date since #7928 gotowner-approved-foreign. It is not changed here: any edit to that file needs the label again. It can be updated in the next PR that has the label.Dmitrii Fedorov (@dmitrii-f-t27)