fix(ci): restore the bit-exact gate a salvage commit overwrote - #5498
Merged
Merged
Conversation
The salvage commit 38eac3a (#4812) committed a bee's unrelated draft over tools/verify_emit_bitexact.py. The draft imports MAXWIDTH from gft_backprop_microcode, which has never defined it, so the Emit Bit-Exact step "Generated RTL is bit-exact to the GF-T model" has failed at import since 2026-09-25 -- hidden behind the generation step that fails before it. Restore the file byte for byte from 38eac3a^. gft_backprop_microcode.py has not changed since, so the check runs unmodified: on 756bcff all 11 topologies are BIT-EXACT over 80 training steps, every module keeps one shared multiplier, and the listed topologies synthesize. Without t27c, --require exits 2 instead of passing. Refs #5497 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Oct 2, 2026
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tools/verify_emit_bitexact.pyis restored byte for byte from38eac3aa^.The salvage commit 38eac3a (#4812, "commit what the turn left uncommitted") put a bee's unrelated draft over this file. The draft imports
MAXWIDTHfromgft_backprop_microcode, which has never defined it, so the step "Generated RTL is bit-exact to the GF-T model on the listed topologies, and they synthesize" has failed at import since 2026-09-25. Nobody saw it, becausecheck_specs_generate.pyfails one step earlier and the job stops there.tools/gft_backprop_microcode.pyhas not changed since38eac3aa^, so the restored check runs unmodified.Evidence, on master 756bcff
synth_xilinxmaps the three listed topologies (13659 / 17182 / 17388 cells).--requireand no t27c it exits 2 (could not run), not 0.What this does not change
The Emit Bit-Exact job stays red until the 15 specs that newly fail to generate are fixed (#5497 lists them). This removes the second failure behind the first one.
Refs #5497
🤖 Generated with Claude Code