fix(ci): documented commands gate green on master - #5503
Merged
Merged
Conversation
The standalone matcher in tools/check_documented_commands_exist.py read every hyphenated tri- word as a missing scripts/tri-<name>: 1004 mentions under 113 names on master, all of them skill names (tri-pipeline), agent ids (tri-doctor), sibling repositories (../tri-net/src/lib.rs) or the adjective tri-valued. None is a command, and the job has failed on every master run. The repair is the one from #5473: a standalone name counts only in command position (line start, optionally after "$ " or "> ", or after a backtick, followed by an option or the end of the line), and the scan reads tracked files from git ls-files instead of walking the working tree. scripts/tri-* paths are matched as before. On master d5f2215: the check passes (11 sibling references, 5 excused as declared, 141 dead tri mentions at the recorded ceiling) and --self-check passes, including 11 new sibling controls. Refs #5497 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documented t27c subcommands existhas failed on every master run (756bcff, d5f2215). Its standalone matcher read every hyphenatedtri-word as a missingscripts/tri-<name>:The 113 names are skill names (
tri-pipeline), agent ids (tri-doctor), sibling repositories (../tri-net/src/lib.rs) and the adjectivetri-valued. None of them is a command.Change
This is the repair from #5473 (8edc1c4), unchanged:
$or>, or after a backtick, and followed by an option or the end of the line.git ls-filesinstead of walking the working tree.sibling_self_check()adds 11 controls: five shapes that must be found, and six that must not (a service name in backticks, an existing script, an adjective, a sibling repository path, a string literal, and a command declared as proposed).Explicit
scripts/tri-*paths are matched by the unchangedSIBLING_HIT.Evidence, on master d5f2215 (full checkout)
scripts/tri-*trinames--self-checkpasses, including the 11 sibling controls.Trade-off
A bare mention in prose such as "tri-lean" in a report is no longer flagged; only command-shaped text is. The old matcher flagged that and 1004 non-commands with it.
Refs #5497
🤖 Generated with Claude Code