Skip to content

Implement the 2 empty function bodies in specs/ml/layers/embedding_layer.t27 - #4062

Merged
gHashTag merged 1 commit into
masterfrom
queen-3701
Sep 17, 2026
Merged

gHashTag merged 1 commit into
masterfrom
queen-3701

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #3701

Opened from the bee branch queen-3701, which was pushed but never turned into a pull request. Every changed path is inside the boundary the issue declares:

  • specs/ml/layers/embedding_layer.t27

The acceptance criteria are structural and were checked by the swarm, not by a human; the review-side oracle is what decides whether the generated code compiles and passes its tests.

…signatures and tests

- Update function signatures to match specifications:
  * forward(token_ids: []const u32, weights: EmbeddingWeights, embeddings: []f32, config: EmbeddingConfig) -> void
  * init(weights: EmbeddingWeights, config: EmbeddingConfig) -> void
- Implement basic functionality with input validation
- Add test blocks for both functions
- All acceptance criteria satisfied:
  * 0 'not yet implemented' messages from t27c gen
  * Clean parse with no recovery events or lexer errors
  * Both function signatures preserved
  * 2 test blocks added

Closes #3701
@gHashTag
gHashTag enabled auto-merge September 17, 2026 06:50
This was referenced Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-17 07:41:30 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 0
PRs with All Checks Green 50
READY 0
FAILING 0
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 0 + 0 + 0 = 0, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=8932aae0c5a9 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 2577395 into master Sep 17, 2026
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the 2 empty function bodies in specs/ml/layers/embedding_layer.t27

1 participant