Skip to content

Generate the clusters data from the Google Doc, with no hand edits - #984

Merged
richarddushime merged 8 commits into
mainfrom
fix/978-cluster-parser-and-note
Nov 4, 2026
Merged

richarddushime merged 8 commits into
mainfrom
fix/978-cluster-parser-and-note

Conversation

@LukasWallrich

@LukasWallrich LukasWallrich commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

data/clusters_v4.json now comes straight from the Clusters v4.1 Google Doc, with no hand edits. Before this change, re-running the parser would have emptied Cluster 11, added false sub-clusters and undone earlier hand fixes.

Parser fixes

  • Handles four formatting quirks in the doc, in Clusters 2, 7, 10 and 11.
  • Keeps references separate when two sub-clusters share a name. Both "Reflexivity and positionality" sections were showing one combined list.
  • Tidies citations returned by doi.org: stray whitespace, "Portico" given as the publisher, surnames in capitals, and a conference title cut off at a line break.

Corrections made in the Google Doc

What visitors will notice

  • The stated sub-cluster count now matches the list on every cluster page, which replaces Correct the sub-cluster counts stated on cluster pages #980.
  • Cluster 10's description no longer starts with the editor's note.
  • Clusters 3 and 10 drop from 133 to 115 and from 194 to 180 references, because each now lists only its own. Total entries go from 1,330 to 1,300.
  • Three new references from the doc appear: Wuttke 2018, Krähmer 2026 and Kwon 2026.
  • Hicks et al. loses its "Ten principles…" note, because entries with a working DOI use the looked-up citation.

Keeping it this way: CONTRIBUTING.md and the parser's docstring now say not to edit the generated files by hand. A new workflow runs the parser tests and the count test (moved from #980) on PRs that touch this data. It can't detect a hand edit that passes those tests, so that part is a rule, not a check.

Verified: the output comes from running the parser against the live doc, using the local DOI cache. All 11 stated counts match, where a cluster states one. The cluster tests pass, a local build (Hugo 0.164) succeeds, and check_seo_html.py exits cleanly.

Timing: data/clusters_v4.json is in the data artifact, so the new text reaches forrt.org after the next data-processing run on main.

Fixes #978
Fixes #964

🤖 Generated with Claude Code

…s note

The Google Doc's formatting had drifted: the parser found no Cluster 11
sub-clusters and read two citations as headings. It also published an
editor's note at the start of Cluster 10's description.

Fixes #978

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LukasWallrich
LukasWallrich requested a review from a team as a code owner November 3, 2026 22:51
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

✅ Spell Check Passed

No spelling issues found when checking 9 changed file(s)! 🎉

@LukasWallrich

LukasWallrich commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Staging Deployment Status

This PR has been successfully deployed to staging as part of an aggregated deployment.

Deployed at: 2026-11-04 17:38:37 UTC
Staging URL: https://staging.forrt.org

The staging site shows the combined state of all compatible open PRs.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread scripts/parse_clusters_to_sheet.py Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LukasWallrich and others added 2 commits November 4, 2026 16:47
Sub-cluster names repeat across clusters, so grouping references by name alone
gave both "Reflexivity and positionality" sections the same combined list. The
export now groups them by cluster as well.

Citations returned by doi.org lose stray whitespace, the "Portico" publisher,
capitalised surnames and titles cut off at a line break. Moves the stated-count
test from #980 here and runs the cluster tests on relevant PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
data/clusters_v4.json and the cluster pages now come from the generator, with no
hand edits. The earlier link, DOI and count corrections were made in the doc.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LukasWallrich LukasWallrich changed the title Make the clusters parser safe to re-run and remove Cluster 10's editor's note Generate the clusters data from the Google Doc, with no hand edits Nov 4, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread scripts/parse_clusters_to_sheet.py Resolved
Comment thread .github/workflows/cluster-tests.yaml Resolved
Comment thread .github/workflows/README.md Resolved
Comment thread scripts/parse_clusters_to_sheet.py Resolved
richarddushime and others added 4 commits November 4, 2026 18:31
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@richarddushime
richarddushime merged commit 914d942 into main Nov 4, 2026
6 checks passed
@richarddushime
richarddushime deleted the fix/978-cluster-parser-and-note branch November 4, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-running the clusters parser would damage clusters_v4.json Cluster descriptions state the wrong number of sub-clusters (clusters 2, 8, 9)

2 participants