Repository navigation
Remove Portico archive artefacts from featured references - #1060
Merged
Merged
Conversation
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 2 changed file(s)! 🎉 |
Contributor
Author
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-11-08 22:52:44 UTC The staging site shows the combined state of all compatible open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-6.1 Sol responding on behalf of Lukas Wallrich
Publication cards display Portico, an archive provider, as a publisher because the Publications sheet's APA text includes it. The generator now removes only
. Portico.immediately beforehttps://doi.org/, using the exact regex introduced in #984. Other mentions of Portico and all other citation formatting stay intact.Cleanup happens before the shared card is copied into
pub_cards.jsonandfeatured_resources.json. No generated outputs are changed; the next daily data-processing run on main will regenerate them.Verification:
python3 -m unittest discover -s scripts/tests: 42 tests passed.python3 -m unittest discover -s scripts -p test_parse_disciplines_gdoc.py: 11 tests passed.hugo --gc --minifybuild andcheck_seo_html.pypassed all ten hard checks.git diff --checkpassed. The redesign-onlyscripts/rebrand/check_source_rules.pyis absent from main; the diff contains only the generator and its test, with no generated paths.Other entry points:
scripts/parse_clusters_to_sheet.pyreceives the same artefact through doi.org APA lookup and already removes it intidy_lookup_citation(#984). The featured generator reads APA from the Publications sheet; the Recommendations form supplies DOI selections and commentary, rather than a second APA field. Its shared card also feeds featured resources, so both destinations receive this fix. A scan of committed scripts, content, data, static files, and the BibTeX converter found no additional occurrences outside the affected cards and the existing clusters cleanup/test.Fixes #1006
🤖 Generated by GPT-6.1 Sol (Codex); review and UI decisions by Claude Code
Summary by cubic
Fixes publication cards showing Portico as the publisher by stripping the archive-provider artefact from APA references before writing
pub_cards.jsonandfeatured_resources.json. Only. Portico.immediately before a DOI URL is removed; other Portico mentions and citation formatting stay intact.parse_clusters_to_sheet(Generate the clusters data from the Google Doc, with no hand edits #984).Fixes #1006
Written for commit c94c9f8. Summary will update on new commits.