Repository navigation
Correct the sub-cluster counts stated on cluster pages - #980
Closed
LukasWallrich wants to merge 1 commit into
Closed
LukasWallrich wants to merge 1 commit into
LukasWallrich wants to merge 1 commit into
Conversation
Clusters 2, 8 and 9 stated stale counts. Cluster 7 stated the right count but listed a citation as a seventh sub-cluster, so that citation returns to Rights retention strategies. A new test keeps the two in step. Fixes #964 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
Author
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-11-04 16:41:16 UTC The staging site shows the combined state of all compatible open PRs. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 3 changed file(s)! 🎉 |
Contributor
Author
|
Superseded by #984 and doc cleanup |
LukasWallrich
added a commit
that referenced
this pull request
Nov 4, 2026
Sub-cluster names repeat across clusters, so grouping references by name alone gave both "Reflexivity and positionality" sections the same combined list. The export now groups them by cluster as well. Citations returned by doi.org lose stray whitespace, the "Portico" publisher, capitalised surnames and titles cut off at a line break. Moves the stated-count test from #980 here and runs the cluster tests on relevant PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
richarddushime
added a commit
that referenced
this pull request
Nov 4, 2026
) * Make the clusters parser safe to re-run and drop Cluster 10's editor's note The Google Doc's formatting had drifted: the parser found no Cluster 11 sub-clusters and read two citations as headings. It also published an editor's note at the start of Cluster 10's description. Fixes #978 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Test that Cluster 10's editor's note stays out of its description Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep each cluster's references separate and tidy looked-up citations Sub-cluster names repeat across clusters, so grouping references by name alone gave both "Reflexivity and positionality" sections the same combined list. The export now groups them by cluster as well. Citations returned by doi.org lose stray whitespace, the "Portico" publisher, capitalised surnames and titles cut off at a line break. Moves the stated-count test from #980 here and runs the cluster tests on relevant PRs. * Regenerate the clusters data from the Google Doc data/clusters_v4.json and the cluster pages now come from the generator, with no hand edits. The earlier link, DOI and count corrections were made in the doc. * Update scripts/parse_clusters_to_sheet.py * Update .github/workflows/README.md * Update scripts/parse_clusters_to_sheet.py --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Richard Dushime <45734838+richarddushime@users.noreply.github.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four cluster pages stated a number of sub-clusters that differed from the list beneath it.
Cluster 7 wasn't in #964; it uses different wording ("This cluster has 6").
Why this edits the JSON directly: a full re-sync from the doc would currently empty Cluster 11 and add a false sub-cluster to Cluster 2 (#978). So this is a scoped edit, as in #826, and
content/clusters/cluster-2/index.mdcomes from re-runninggenerate_cluster_pages.py.Needs a content decision: the doc still says 8 for Cluster 2 and names "Survey Design & Analysis", which has no section there. If that sub-cluster is restored, the count goes back to 8. This PR describes what the site lists today.
Timing:
data/clusters_v4.jsonis in the data artifact, so the new text reaches forrt.org after the next data-processing run onmain.Verified: in a local build (Hugo 0.164) the stated count equals the number of sections on clusters 2, 7, 8 and 9.
scripts/tests/test_clusters_data.pyis new and fails on all four clusters without the data change.check_seo_html.pyexits cleanly.Fixes #964
Created with Claude Opus 5.5 in Claude Code.
Summary by cubic
Corrects the stated sub-cluster counts on cluster 2, 7, 8, and 9 pages so they match the sub-clusters actually listed beneath them.
scripts/tests/test_clusters_data.py, which fails on all four clusters without the data change.Migration
data/clusters_v4.jsonis in the data artifact, so the corrected text reaches forrt.org after the next data-processing run onmain. The Google Doc still states 8 sub-clusters for cluster 2 and names "Survey Design & Analysis", which has no section there; if that sub-cluster is restored later, the count should go back to 8.Written for commit 9f6b04b. Summary will update on new commits.