Repository navigation
Render Markdown in glossary term titles and related terms - #1085
Conversation
Term titles in the A–Z list, breadcrumb and heading now go through markdownify, so 'Research Contribution Metric (*p*)' shows an italic p. The page <title>, og:title and JSON-LD get the plain-text form. Related terms drop '*' and '\' before building the link slug and render their Markdown, so '*P*\-hacking' links to p-hacking and shows italic. check_seo_html.py gains check 17, which fails if a glossary page's <title> or <h1> shows paired asterisks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ Spell Check PassedNo spelling issues found when checking 9 changed file(s)! 🎉 |
… title check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…n check 18
A shared functions/plain_title partial now feeds <title>, og:title, the
DefinedTerm name and collection ListItem names, so none of them shows
'(*p*)'. Check 18 no longer treats asterisks inside words
('G*Power and P*Hack') as a Markdown pair.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
plain_title now takes the text to clean, so the breadcrumb and ListItem names keep .LinkTitle while <title> and the DefinedTerm name use .Title. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pages compare_builds.py flags any SEO tag change. These five pages' <title>, og:title and JSON-LD name now read '(p)' instead of '(*p*)', which is the intended effect of rendering glossary title Markdown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note 🤖 Claude Opus 5.5 responding on behalf of Lukas Wallrich No change needed for the image warning. The three references are existing lines in |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
CI builds with main's data artifact (slug without 'p_'); a local build from the content committed on this branch still produces 'p_مقياس…'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le-markdown # Conflicts: # scripts/check_seo_html.py
#1085 took check 18 for glossary titles, so the cluster-title check is now check 19, in both the docstring and the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note 🤖 Claude Opus 5.5 responding on behalf of Lukas Wallrich @richarddushime, this has already been merged into
|
Glossary term titles and related terms now render their inline Markdown. This is content-review item clusters-glossary-31, alternative 2.
What changes
layouts/partials/doors/term_title.htmlescapes the title and runs it throughmarkdownifybefore the<bdi>wrap. The A–Z side card, the breadcrumb and the<h1>now show "Research Contribution Metric (p)" with an italic p, not(*p*). Slugs anden_titlematching are unchanged.layouts/partials/functions/resource_metadata.htmlgives glossary pages a plain-text title (markdownify | plainify) for<title>,og:titleand JSON-LD. Those now read "Research Contribution Metric (p) | FORRT".layouts/glossary/single.html, related terms:*and\are stripped before the slug is built.markdownify.*P*\-hackingand*P*\-value fishing. They now link to/glossary/english/p_hacking/and show an italic P; before, they showed the raw text with no link.scripts/check_seo_html.py: new hard check 18 fails (numbered 18 because Render italics and small caps in publication titles on cluster pages #1083 adds a 17) if a glossary page's<title>or<h1>shows paired asterisks. A lone asterisk passes, as in "G*Power". Unit tests are added. With the old title partial the check fails onglossary/english/research_contribution_metric__p_/.Launch step: restore the italic p in related terms
On 8 November, ten
Related_termscells in the Glossary sheet (tabglossaries) were changed to plain text, becausemainshows the asterisks as typed and the asterisks break the link slug. Once this branch is live, the italics can go back. Use lowercase, with no backslash:p-value*p*-valuep-hacking*p*-hackingp-hacking; p-value*p*-hacking; *p*-valuep-hacking; p-value fishing; … Reverse p-hacking*p*-hacking; *p*-value fishing; … Reverse *p*-hackingp-value*p*-valueTerm titles stay plain ("p-value", "p-hacking"), because an asterisk in a title changes its slug (
_p_value).Not changed
**ا**لانحياز التَّوكيديّ. It now renders with its first letter in bold, where before it showed asterisks. This is a data issue in the sheet; it is listed for the Arabic team in Turkish glossary: MOOCs entry shows the JabRef definition #933 (comment).Checks:
hugo --gc --minifybuilds.scripts/check_seo_html.pypasses all checks, including the new check 18. The unit tests pass (130). I looked at the built term pages and the A–Z list.🤖 Generated with Claude Code