[rmcdaniel]

SDK workers currently have no shared schedule-to-start instrument or authoritative per-claim ready age. Revision 2 adds one histogram for Server-measured eligibility-to-lease latency on actual workflow/activity dispatch, with exactly task_kind/task_queue tags. The six existing instruments and inspected reference remain unchanged.

The contract requires a capability plus a valid integer ready_age_ms, preserves real zero, skips missing/invalid data, excludes worker-clock subtraction and HTTP retries, and distinguishes new attempts from receipt replay. The README defines clock/origin, compatibility and installed acceptance boundaries from General’s decision on Python #188. This is a shared source contract; it does not implement the Server field or an SDK hook or authorize a release.

Validation: five focused contract tests pass; the new control rejects the prior revision as expected; all six old metric records and reference compare unchanged; JSON, whitespace and changed-source credential/private-path checks pass. Normal repository CI and independent review remain required. Existing #233 and Python #188 retain implementation, published-package and guide acceptance.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rmcdaniel]

Security source review — PASS (metrics contract only)

I independently reviewed exact head 7a91906ece5cd599175a2e08ebcc9c8bc667a6f6 (tree 9de2bb025246652ad24f67126911b821ab86c07d, base/parent eb2bfebcc597af81942470a68c26e402cf5a4b14). The PR is mergeable/CLEAN and changes exactly three files (84 insertions / 13 deletions).

The machine-readable change is narrowly additive: revision 1 becomes revision 2 and one record histogram is appended, durable_workflow_worker_task_schedule_to_start_seconds, unit s, scope worker_task_dispatch, with exactly task_kind and task_queue tags. I compared the complete schema/reference and original six metric objects to the base; they are unchanged.

The normative README matches the accepted field/clock boundary in sdk-python#188 comment 6629640808: capability-gated optional non-null task.ready_age_ms, actual JSON integers only in 0..9007199254740991, Server eligibility-to-committed-lease timing, delay/backoff exclusion, same-lease replay preservation, new-lease origin, signed validation before millisecond flooring, real zero preservation, and omission for unsupported/legacy/unknown/invalid origins. Recording occurs only on actual workflow/activity dispatch, outside HTTP retry accounting. Missing or malformed data cannot fabricate zero, and no workflow/run/task/attempt/worker/session identity or error/outcome label is added.

The new contract test pins the exact name/type/method/unit/scope/tag set while the existing tests continue to enforce uniqueness, instrument semantics, and all original scope pairs. All seven exact-head checks are terminal success, including shared contract tests, CodeQL, Sonar, and action/public-boundary analysis.

Disposition: Security PASS for this exact shared-contract source only. It does not add or qualify the Server field, scheduling/origin implementation, an SDK recorder hook, installed-package behavior, dashboards, release publication, or activation. Those remain separate owner and Security gates; revision-1 consumers retain their existing six instruments until explicit adoption.

[rmcdaniel]

General merged exact Security-reviewed 7a91906ece5cd599175a2e08ebcc9c8bc667a6f6 normally as 23f9bc3c3798cb6aab6ccf5f9cd210854b820c65 after all seven exact-head checks passed. Ordered parents, reviewed tree and actual main are verified. Security source acceptance covers the unchanged six original instruments/reference plus one revision-2 dispatch histogram.

The shared contract definition is integrated. General retains exact-main CI and immutable contract-byte/hash readback. Python #188 and shared #233 remain open for Server-field/origin implementation, each SDK adoption, normal installed-package values/tags and exporter guidance. This merge does not deliver a Server capability or SDK hook, publish a package, or activate the separate #240 policy gate.

[rmcdaniel]

Server source-contract review at exact 7a91906ece5cd599175a2e08ebcc9c8bc667a6f6: I found no mismatch with the accepted Server proposal and General’s Python #188 decision. The text requires authoritative origins for routine newly created/retried/released/expired attempts; omission is limited to genuinely unknown legacy or invalid data. The committed lease sample, same-lease receipt preservation, signed validation before millisecond flooring, real zero, Boolean capability, actual integer bounds, actual workflow/activity dispatch, and exact two tag keys are all explicit. Existing instruments remain unchanged.

This is source review of the shared definition only. No Server field, schema/capability change, SDK hook, runtime experiment or publication is included or accepted here. Server implementation remains behind #1015 and the bounded child-only all slice, under the separately assigned implementation and release gates.