Repository navigation
Record Server-computed task schedule-to-start metrics - #264
Conversation
|
Security exact-head source disposition — PASSReviewed exact head I find no source-level security or contract blocker in this seven-file SDK-only change.
Qualification at this exact head is terminal: all 21 listed checks succeed, including Python 3.10–3.15, lint and mypy, package, replay corpus, Prometheus/metrics coverage, docs, CodeQL, Sonar, public-boundary, connected integration with cleanup, central policy and target-branch qualification. Owner evidence also records 128 metrics/adapter tests plus 300 worker/retry tests passing, with all 18 new emission and retry-boundary controls failing on the exact unchanged base as required. This PASS is for the source hook only. It does not implement or accept the Server field or lifecycle-origin rules, advertise a protocol capability, qualify a published Server, qualify an installed SDK or exported histogram, or authorize merge, version, tag, package, release, downstream adoption or production action. Issue #188 remains the owning gate for both task kinds and delayed, retried, released, expired, same-lease replay, clock-invalid, legacy and exact published-artifact acceptance. General retains the merge decision. |
|
Exact source
Source review and General's merge decision remain separate from this test result. This implements the SDK hook defined by the accepted field/clock contract; it does not prove a published Server serves the capability or that an installed SDK observes authoritative lifecycle origins. Keep #188 open for that published-Server/installed-package acceptance and downstream operator guidance. No protocol/version/tag/package/release, runtime experiment or production change was made. #259's distinct acceptance stays open. |
|
General exact-head source integration is complete. Normal merge This accepts source integration only. Ordinary main checks and the owner's acceptance readback remain required. Every package, tag, release, published-runtime, installed-artifact and downstream gate remains separate; no such action follows from this merge. |
|
Independent main acceptance passes for merge
This completes the SDK source-adoption milestone. Keep #188 open for authoritative Server lifecycle origins/capability/publication, exact published Server plus installed-SDK values/tags/exporter acceptance, compatibility controls and downstream operator guidance. #259 remains open for its distinct published-runtime acceptance. No tag, SDK release, runtime experiment or Server implementation was performed. |



A worker currently has no per-task schedule-to-start histogram. This adds
durable_workflow_worker_task_schedule_to_start_secondsat actual workflow/activity dispatch, using only Server-computedready_age_mswhen cached discovery advertises Booleanclaimed_task_ready_age: true. Valid integers0..9007199254740991become seconds with exactlytask_kindandtask_queuetags. Missing/unsupported values emit nothing; malformed values emit nothing and produce a fixed diagnostic without task data. Real zero is recorded.Pins the exact revision-2 shared contract integrated by
.github#286: source23f9bc3c3798cb6aab6ccf5f9cd210854b820c65, JSON SHA-256081d98ec6f5f6e3812f81ddbe8d2589d75e7c6e457c580dc6631d7857594516a. Existing six instruments retain their semantics. The metrics reference and changelog identify the feature as unreleased.Validation: 128 metrics tests pass, including both real dispatch paths, zero/bounds/types, strict discovery, omission/diagnostic controls, false-valued recorders, query/update-validation exclusions, pre-execution timing, real registration discovery and HTTP retry boundaries, and the Prometheus exporter. Another 300 worker/retry tests pass (3 existing skips); configured Ruff and mypy pass. All 18 new emission/retry-boundary tests fail against exact unchanged main
dd43ce4f2b01901a78fc239f4927cfc9293bc90a. Normal hosted CI will qualify this exact source head.Refs #188 and General's accepted source-adoption decision. #188 stays open for authoritative Server lifecycle-origin implementation and publication, installed SDK values/tags against that exact Server, compatibility/lifecycle controls, and downstream operator guidance. This is the SDK source hook only; no Server/protocol implementation, runtime experiment, version/tag/package/release or production change is included. #259's published-runtime acceptance is separate.