fix(tipping): show the below-minimum tip prompt as info, not an alert - #1361
Merged
Conversation
Entering a minimum tip under the floor put up a destructive red banner. The design calls for the info style: nothing has failed and nothing is being destroyed, the entry is just too low and needs raising. Saving still fails loudly. Also drops the Figma node ids from these files' KDoc — they don't survive file edits, so they go stale without anyone noticing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1360.
Entering a minimum tip under the floor put up a destructive red banner. The design calls for the info style — nothing has failed and nothing is being destroyed, the entry is just too low and needs raising. Saving still fails loudly, since that one is a real failure.
Also drops the Figma node ids from these files' KDoc. They don't survive file edits, so they go stale without anyone noticing.