feat(messenger): left-align the in-chat amount entry - #1362
Merged
Conversation
The tip and cash DM screens used the centred amount field with its currency flag. The updated design puts the amount at the screen inset under the app bar with the hint beneath it — the layout AmountEntryScreen already renders behind `largeHeader`, and the one the minimum-tip entry uses. The chat screen opts in; no new layout code. Setting a tip needs the recipient's minimum stated somewhere, and the flag was not carrying it. A tip chat has both bounds, and the delegate has always described the ceiling, so the "enter up to" hint held the line while the floor — the rule the sender is likely to break — only appeared as an error after they broke it. AmountEntryStyle.standingHint lets a flow say which bound the resting hint describes; the chat's tip style picks the floor. Everything else keeps the ceiling by default, and errors are unchanged: an amount outside either bound still reports the bound it broke. The chat's below-minimum prompt also becomes showInfo rather than showAlert. Nothing has failed and nothing is being destroyed — the entry is under the recipient's floor and needs raising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tip and cash DM screens used the centred amount field with its currency flag. The updated design puts the amount at the screen inset under the app bar with the hint beneath it — the layout
AmountEntryScreenalready renders behindlargeHeader, and the one the minimum-tip entry uses. The chat screen opts in; no new layout code.Setting a tip needs the recipient's minimum stated somewhere, and the flag was not carrying it. A tip chat has both bounds, and
AmountEntryDelegatehas always described the ceiling, so the "enter up to" hint held the line while the floor — the rule the sender is likely to break — only appeared as an error after they broke it.AmountEntryStyle.standingHintlets a flow say which bound the resting hint describes; the chat's tip style picks the floor. The other consumers (withdrawal, tipping, minimum-tip, swap, cash DM) keep the ceiling by default. Errors are unchanged: an amount outside either bound still reports the bound it broke.The chat's below-minimum prompt also becomes
showInforather thanshowAlert, the same correction #1361 makes on the profile path.Not in this change
TokenSelectionPill. Swapping it would remove the token switcher, which the design does not replace, so it stays.largeHeaderdrops it, matching the design — this screen is denominated in the preferred currency, changed from settings.TipAmountEntryScreen. The tip-card sheet is a different screen and is not in these frames; it is still centred.