Skip to content

fix(tipping): show the below-minimum tip prompt as info, not an alert #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Aug 28, 2026
Merged

fix(tipping): show the below-minimum tip prompt as info, not an alert #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../flipcash/features/menu/src/main/kotlin/com/flipcash/app/menu/internal/ProfileTutorial.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import com.flipcash.app.core.ui.onboarding.TutorialItem
import com.flipcash.services.models.UserProfile

/**
* The "Finish Your Profile" checklist for the "You" tab (node 9544:18140).
* The "Finish Your Profile" checklist for the "You" tab.
*
* Null while the profile is unresolved, so the card is never drawn against a guess — an account
* that already has a photo would otherwise flash an outstanding step on the way in. Null again once
Expand Down
4 changes: 2 additions & 2 deletions ...ile/src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import kotlinx.coroutines.flow.launchIn
import kotlinx.coroutines.flow.onEach

/**
* Minimum-tip entry (nodes 9541:10951, 9553:113170). Leaving without saving discards the entry —
* there is no draft to keep, so a changed-but-abandoned amount just doesn't reach the profile.
* Minimum-tip entry. Leaving without saving discards the entry — there is no draft to keep, so a
* changed-but-abandoned amount just doesn't reach the profile.
*
* @param isLastStep whether the flow ends here, which is the only thing that decides between
* "Save" and "Next".
Expand Down
8 changes: 5 additions & 3 deletions .../src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ import javax.inject.Inject
import kotlin.math.abs

/**
* Backs the minimum-tip entry screen (nodes 9541:10951, 9553:113170) — the fee another user has to
* pay to open a DM, which the profile carries as `minDmChatInitFee`.
* Backs the minimum-tip entry screen — the fee another user has to pay to open a DM, which the
* profile carries as `minDmChatInitFee`.
*
* Two things separate it from the send-side tip entry: there is no ceiling, since a user can ask
* for any amount regardless of what anyone can afford, so the preset minimum is the only bound and
Expand Down Expand Up @@ -151,7 +151,9 @@ internal class MinimumTipEntryViewModel @Inject constructor(

val min = minimumAmount.value
if (min != null && amount.valueLessThan(min)) {
BottomBarManager.showAlert(
// Info, not alert: nothing has gone wrong and nothing is being destroyed —
// the entry is just under the floor and needs raising.
BottomBarManager.showInfo(
title = resources.getString(R.string.error_title_minimumTip, min.formatted()),
message = resources.getString(R.string.error_description_minimumTip),
)
Expand Down
Loading