chore(services): consume the client-protocol artifacts from Maven Central - #1325
Merged
Conversation
Swaps :definitions:opencode:models for com.codeinc.opencode:ocp-client-protocol, resolved from mavenLocal, to check that the generated client works as an external dependency rather than an in-repo codegen module. It does. :services:opencode compiles, its 603 unit tests pass, and the full debug APK builds. protovalidate-runtime and kotlinx-coroutines-core now arrive transitively from the artifact's POM instead of being declared here. Proof of concept, not the migration: the :definitions:opencode modules are still in settings.gradle.kts, and the version is a local snapshot that CI cannot resolve. Both go away once ocp-client-protocol publishes for real.
Follows ocp-client-protocol publishing under com.flipcash instead of com.codeinc.opencode. The imported package is unaffected.
Swaps :definitions:flipcash:models for com.flipcash:flipcash2-client-protocol, resolved from mavenLocal, mirroring what :services:opencode already does. It works the same way. :services:flipcash compiles, its 220 unit tests pass, and the full debug APK builds with both services on artifacts. dependencyInsight confirms genuine external-module resolution with :definitions:flipcash:models off the classpath. The swap is contained because every com.codeinc.flipcash.gen.* import in the app lives under this module, and the dependency was already implementation, so nothing downstream sees it. Proof of concept, not the migration: the :definitions:flipcash modules are still in settings.gradle.kts, and the version is a local snapshot that CI cannot resolve. Both go away once flipcash2-client-protocol publishes for real.
ocp-client-protocol and flipcash2-client-protocol 0.1.0 are on Maven Central, so the mavenLocal snapshots are no longer needed. Both modules build and pass their unit tests against the published jars (603 opencode, 220 flipcash).
github-actions
Bot
added
type: chore
…alog Every other external dependency in these modules comes from libs.versions.toml; these two were the only hardcoded coordinates.
github-actions
Bot
added
the
area: build-system
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:services:opencodeand:services:flipcashnow depend on published packages instead of thein-repo generated proto modules:
Both artifacts are on Maven Central, generated by
ocp-client-protocol and
flipcash2-client-protocol from the
same upstream contracts this repo vendors today. Their generated Kotlin is byte-identical to what
:definitions:*:modelsproduces — 263 files for OCP, 526 for Flipcash, checked per generator andgated in each repo's CI. That equivalence is why this is a two-line change and not a migration.
Artifact coordinates and generated namespace are deliberately different. The packages publish
under
com.flipcash; the code inside stays incom.codeinc.opencode.gen.*andcom.codeinc.flipcash.gen.*, which is set byjava_packagein the protos. No imports move.Two dependencies that the app's graph used to supply incidentally are now declared by the
artifacts themselves:
protovalidate-runtimeandkotlinx-coroutines. The generated grpckt stubsreference
kotlinx.coroutines.flow.Flow, and a standalone artifact cannot rely on picking that upfrom a consumer.
:definitions:opencode:modelsand:definitions:flipcash:modelsnow have no consumers. They stayin place here — removing them, along with the
fetch-protos.shmachinery behind them, belongs inits own change once iOS also consumes the packages.