chore(definitions): delete the vendored protos and their codegen - #1326
Merged
Conversation
:services:opencode and :services:flipcash now compile against
com.flipcash:{ocp,flipcash2}-client-protocol (#1325), so the four :definitions:*
modules generate output nobody depends on. Nothing outside definitions/ referenced
them — the models modules were consumed only by the services, and the protos
modules only by their own models — so the whole directory goes, along with
scripts/fetch-protos.sh, which pulled the .proto copies that are no longer here.
That leaves the protobuf Gradle plugin and protovalidate plugin applied nowhere,
so their catalog aliases and the protobuf-plugin version go too. The protobuf,
grpc-kotlin, and protovalidate-kt versions stay: the runtime artifacts they pin
are still dependencies of the services and libs/encryption.
Docs and the /fetch-protos skill described a workflow that no longer exists —
fetch upstream .protos, run protoc here, build :definitions:*:models. Rewritten
around what actually happens now: find the release, bump the pin, diff the
contract between tags, build the service module. The skill keeps its scaffolding
half, which is unaffected. 13-protobuf-and-codegen.md is largely rewritten.
Verified on device: 603 opencode and 220 flipcash unit tests pass, the debug APK
builds and installs, and the launched app reaches a signed-in session with live
balances over real RPCs.
github-actions
Bot
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1325. With
:services:opencodeand:services:flipcashcompiling againstcom.flipcash:{ocp,flipcash2}-client-protocol, the four:definitions:*modules generate output nobody depends on.Nothing outside
definitions/referenced them — themodelsmodules were consumed only by the services, and theprotosmodules only by their ownmodels— so the whole directory goes, along withscripts/fetch-protos.sh, which pulled the.protocopies that are no longer here.That leaves the protobuf Gradle plugin and the protovalidate plugin applied nowhere, so their catalog aliases and the
protobuf-pluginversion go too. Theprotobuf,grpc-kotlin, andprotovalidate-ktversions stay: the runtime artifacts they pin are still dependencies of the services andlibs/encryption.Docs
/fetch-protosanddocs/architecture/13described a workflow that no longer exists — fetch upstream.protos, run protoc here, build:definitions:*:models. Both are rewritten around what actually happens now: find the release, bump the pin, diff the contract between tags withgh api .../compare, build the service module. The skill keeps its scaffolding half, which is unaffected by any of this.Smaller edits follow the same thread through
CLAUDE.md, the root README, the architecture docs' module tables and dependency graphs, the glossary, both service READMEs,proto-change-tracer, and thedefinitions/**globs in the PR labeler.