chore: retire the parity gate - #1
Merged
Merged
Conversation
verify-parity.sh compared this repo's generated output against the copy each app generated for itself. Both apps now consume this package instead of generating — code-android-app#1325 and code-ios-app#645 delete the vendored protos and the codegen that fed them — so there is no second output left to compare against. The script's own header said to delete it at this point. What the gate was actually protecting is generator drift, and that protection moves entirely to scripts/toolchain.env: grpc-swift-2 reaches the plugin through a floating `from:` requirement, so the Swift moves on a transitive release with no contract change and nothing downstream to catch it. Its comment says so directly now. The READMEs' Status sections were written around the gate and around "never published, no app depends on it," both of which stopped being true at 0.1.0. Rewritten to record what the comparison found rather than to promise it stays green.
The consumer PRs merged, so the Status sections' "open, not merged" no longer holds. Drops the "Not done yet" heading; the coordinates-vs-namespace note under it is a standing fact, not an open item, so it keeps its own heading here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify-parity.shcompared this repo's generated output against the copy each app generated foritself. Both apps now consume this package instead of generating —
code-android-app#1325 and
code-ios-app#645 delete the vendored
protos and the codegen that fed them — so there is no second output left to compare against. The
script's own header said to delete it at this point.
Merge this after both consumer PRs land. Until they do, the gate still has something to
compare against and still works.
What replaces it
Nothing, for contract drift — that failure mode is gone by construction once there is one
generation point.
For generator drift the protection moves entirely to
scripts/toolchain.env. grpc-swift-2reaches the plugin through a floating
from:requirement, so the Swift output moves on atransitive release with no contract change; 2.2.1 and 2.3.0 each rewrote hundreds of lines that
way. The gate used to catch that incidentally. Now the pins are the only thing that does, and
the comment in that file says so instead of pointing at the deleted script.
README
The Status section was built around the gate and around "never published to a real registry, and
neither app depends on it on a branch" — both false since
0.1.0. It now records what thecomparison found, in the past tense, rather than promising it stays green.