Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…alytics and run it on CI Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…errors and player state Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…annel Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
… the session Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
maintenance/conviva-tests
branch
from
November 19, 2026 10:23
fde7b17 to
f86a7b6
Compare
ceyhun-o
marked this pull request as ready for review
November 19, 2026 11:25
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
…ration Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Danesz
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first automated tests for the Conviva connector, in a new
THEOplayerConnectorConvivaTestsSwiftPM target with a shared scheme. The target is also added to the CI test loop.The only production change is a test seam.
ConvivaEndpointsgets an internalinit(analytics: CISAnalytics), so tests can inject a recording fake that captures every call to the Conviva SDK. There is no public API change.The test target depends on
THEOplayerTHEOliveIntegration,THEOplayerTHEOadsIntegrationand Google IMA (iOS only, which the OptiView Ads integration's module imports). Only the test target uses them, so SwiftPM consumers of the connector products don't fetch them.The tests drive a real
THEOplayer(most SDK events have no public init) and cover these areas:https://cdn.theoplayer.com/video/elephants-dream/404/index.m3u8, where the 4th video segment returns HTTP 403.isLiveis not overwritten.demochannel, and a customer-provided value wins.Results
GitHub CI (Xcode 26.3) passes: 32/32 Conviva tests, including the 3 OptiView Ads interstitial tests. The Sideloaded Subtitle (36) and Uplynk (49) suites, which run after Conviva in the CI loop, also pass.
Known gap, not covered by a test: on HESP/THEOlive,
Conviva.streamUrlstays"unknown". It is captured on SOURCE_CHANGE, and the later CURRENT_SOURCE_CHANGE only updatesencoding_type.Link to Devin session: https://dolby.devinenterprise.com/sessions/50c8aced921146a9b29941f29ac495cd
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/50c8aced921146a9b29941f29ac495cd?variant=devin
Requested by: @ceyhun-o