Repository navigation
Conviva: do not report Paused state after the session has ended - #138
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
THEOplayer on iOS dispatches PAUSE right after ENDED. By then the connector has already called reportPlaybackEnded() and cleanup() on the Conviva video analytics, so the Paused state was reported on an ended session. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
devin-ai-integration
Bot
force-pushed
the
bugfix/conviva-pause-after-ended
branch
from
November 19, 2026 09:32
dec7477 to
6c70b21
Compare
therama
approved these changes
Nov 19, 2026
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS, THEOplayer dispatches
PAUSEabout 1 ms afterENDED, when AVPlayer drops its rate to 0 at the end of the stream. By thenPlayerHandler.endedhas already reportedCONVIVA_STOPPEDandmaybeReportPlaybackEnded()has calledreportPlaybackEnded()andcleanup().PlayerHandler.pausethen reportedCONVIVA_PAUSEDon the ended, cleaned-up session.playerStateis still updated, so a new session that starts later sees the correct state. The Web connector behaves the same way: it drops its Conviva object at session end, so a late pause isn't reported.Verification was on an iPhone 17 simulator (iOS 26.5, Xcode 26.6):
SessionLifecycleTests.testEndedReportsStoppedAndEndsSession, which fails without it.What Conviva does with a state report after
cleanup()was not observed, because the Conviva gateway was unreachable from the test VM.Link to Devin session: https://dolby.devinenterprise.com/sessions/50c8aced921146a9b29941f29ac495cd
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/50c8aced921146a9b29941f29ac495cd?variant=devin
Requested by: @ceyhun-o