Repository navigation
Conversation
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: OPTI-5174
For
TheoLiveSource(channelId: "demo")the iOS Conviva connector sentConviva.streamUrl = "unknown".The connector stores
player.srcon SOURCE_CHANGE. On iOS that is the internally selected source, and for THEOlive it is nil at SOURCE_CHANGE and still nil at PLAY, because the endpoint resolves asynchronously. So moving the read to PLAY, as Android and Web do, would not help on iOS.theolive://main/demo. Android and Web also report the app-set THEOlive source (the channel id), and none of the three update it mid-session.player.srcis non-nil (HLS, DASH, OptiView Ads). Google DAI hasplayer.src == "", not nil, so it still reports"".setContentInfoupdate.Tests: the regression test
SourceChangeTests.testTHEOliveStreamUrlUsesAppSetSourceneeds the test infrastructure from #137. It is kept as a separate commit and will be added once #137 is merged."unknown"instead of"theolive://main/demo") and passes with it.Link to Devin session: https://dolby.devinenterprise.com/sessions/87502d1de3ca43e1847d3f8cfcc0b824
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/87502d1de3ca43e1847d3f8cfcc0b824?variant=devin
Requested by: @ceyhun-o