Skip to content

Conviva: report the THEOlive source as stream URL instead of "unknown" - #143

Draft
ceyhun-o wants to merge 1 commit into
mainfrom
bugfix/conviva-streamurl-theolive
Draft

ceyhun-o wants to merge 1 commit into
mainfrom
bugfix/conviva-streamurl-theolive

Conversation

@ceyhun-o

@ceyhun-o ceyhun-o commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Jira: OPTI-5174

For TheoLiveSource(channelId: "demo") the iOS Conviva connector sent Conviva.streamUrl = "unknown".

The connector stores player.src on SOURCE_CHANGE. On iOS that is the internally selected source, and for THEOlive it is nil at SOURCE_CHANGE and still nil at PLAY, because the endpoint resolves asynchronously. So moving the read to PLAY, as Android and Web do, would not help on iOS.

- newSource = .init(description: source, url: selectedSource ?? "unknown")
+ newSource = .init(description: source, url: selectedSource ?? source.sources.first?.src ?? "unknown")
  • THEOlive: now reports the app-set source theolive://main/demo. Android and Web also report the app-set THEOlive source (the channel id), and none of the three update it mid-session.
  • Other sources: unchanged whenever player.src is non-nil (HLS, DASH, OptiView Ads). Google DAI has player.src == "", not nil, so it still reports "".
  • Not used: the resolved HESP URL from CURRENT_SOURCE_CHANGE. It would mean something different from Android/Web and need a mid-session setContentInfo update.
  • History: capturing at SOURCE_CHANGE dates from the original connector (2022), before THEOlive support. Nothing shows it was chosen for THEOlive, so this looks like an oversight.

Tests: the regression test SourceChangeTests.testTHEOliveStreamUrlUsesAppSetSource needs the test infrastructure from #137. It is kept as a separate commit and will be added once #137 is merged.

Link to Devin session: https://dolby.devinenterprise.com/sessions/87502d1de3ca43e1847d3f8cfcc0b824
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/87502d1de3ca43e1847d3f8cfcc0b824?variant=devin
Requested by: @ceyhun-o

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant