Skip to content

fix: restore global etf runtime selection - #713

Merged
Pigbibi merged 2 commits into
mainfrom
fix/global-etf-runtime-selection-review-20261101
Nov 1, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/global-etf-runtime-selection-review-20261101

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Prepared and reviewed locally with OpenAI Codex (GPT-6).

What changed

Restore Global ETF runtime selection and its existing aliases for compatible targets, following the owner's explicit 2026-11-01 restoration decision. Keep Russell Top50 and all other profiles unchanged. Align both READMEs and the research index, preserving the independent Global ETF research assessment of rework.

Correct the adapter-coverage regression that still classified Global ETF as historical-only. Retain rejection tests for research-only and unknown profiles and explicit platform restrictions. No dependency pins, deployments, broker controls or trading actions are changed.

Companion settings PR: QuantStrategyLab/QuantRuntimeSettings#1016

How verified

  • Reviewed the full PR diff and the runtime catalog/adapter consumers.
  • Ruff and documentation validation passed (0 blocking, 4 existing advisories).
  • Local focused Python tests were stopped after prolonged native-library loading on macOS; no local test pass is claimed. The full remote unit-test suite and all four research integration/consumer jobs passed.
  • The adapter-coverage regression is corrected and passed in the full remote suite.
  • Squash merge and the owner-approved label are explicitly authorized by the owner for this task, after review and passing CI.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 67a30aa3-7835-4709-96df-be7977460a07
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pigbibi
Pigbibi marked this pull request as ready for review November 1, 2026 07:54

@Pigbibi Pigbibi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review completed against the full seven-file diff. Global ETF and its aliases regain selection for compatible platforms; existing selectable profiles and explicit platform restrictions remain. Both READMEs and the research index agree, while the research evidence remains rework. The stale historical-only adapter assertion is corrected. Full unit-test CI and all four research integration/consumer jobs passed, as did Ruff/docs/governance checks other than the owner label gate. Local focused Python tests were stopped during native-library loading on macOS and are not claimed as passing. No deployment, dependency pin or trading control change. No blocking findings.

@Pigbibi Pigbibi added the owner-approved Owner approval for high-risk PRs. AI agents must never apply this label. label Nov 1, 2026 — with ChatGPT Codex Connector
@Pigbibi
Pigbibi merged commit c98e5c2 into main Nov 1, 2026
@Pigbibi
Pigbibi deleted the fix/global-etf-runtime-selection-review-20261101 branch November 1, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner approval for high-risk PRs. AI agents must never apply this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant