Skip to content

fix: Restore Global ETF runtime selection - #712

Closed
Pigbibi wants to merge 1 commit into
mainfrom
fix/restore-global-etf-runtime-20261101
Closed

Pigbibi wants to merge 1 commit into
mainfrom
fix/restore-global-etf-runtime-20261101

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #713. The replacement contains the identical source tree with a commit subject that satisfies commitlint. This draft and its branch are retained without merging or rewriting history.

AI assistance

Prepared with OpenAI Codex (GPT-6). The assistant implemented the patch and ran the checks below.

What changed

The runtime cleanup removed global_etf_rotation from the explicit selection allowlist, preventing compatible new targets from selecting it even though catalog metadata remains runtime-enabled. Restore global selection eligibility and existing aliases while preserving Russell Top50 and all other allowed profiles. Update the catalog expectation and README.

This is selection eligibility only. Platform policy, snapshot evidence, broker gates, dependency pins, and execution authorization remain separate. No deployment or trading action is included. Companion settings draft: QuantStrategyLab/QuantRuntimeSettings#1015

How verified

  • Before the allowlist fix: regression tests produced 7 failures, 16 passes, and 29 passing subtests.
  • After the fix: allowlist, catalog, and Global ETF strategy tests passed (29 tests and 29 subtests), covering aliases, new compatible platform targets, explicit platform restrictions, and rejection of research-only and unknown profiles.
  • Repository Ruff, documentation checks, and git diff --check passed; documentation reported 4 advisories.

Draft for review. Leave unmerged and without labels. The risk gate requiring an owner-approved label is intentionally not satisfied by this request.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant