Repository navigation
fix: restore global etf selection for new targets - #1016
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
left a comment
There was a problem hiding this comment.
Self-review completed on the final head after integrating current main. Deep comparison confirms exactly six Global ETF source fields change: frozen, runtime_enabled, lifecycle_stage, can_switch_live, allowed_execution_modes and blocked_live_reason. All other strategies, live_continuity, existing targets and risk/broker policies are unchanged. The other diff files are generated projections/bundle and directly related tests or the historical-policy compatibility fix. The old candidate retains its original 14-profile freeze policy and exact identity checks; current Global ETF restoration does not rewrite that baseline. Full Python and JavaScript CI passed for both PR and push events, including the fixed-candidate compatibility job and producer roundtrip. Local 175 Python tests, frozen-selection/HTTP validations, account-settings Worker/state validations, historical freeze tests and frontend build/asset checks passed. No blocking findings. No deployment, IAM, secrets or trading action is included.
AI assistance
Prepared and reviewed locally with OpenAI Codex (GPT-6), in a separate clone.
What changed
Restore Global ETF selection and live eligibility following the owner's explicit 2026-11-01 decision: unfreeze, enable runtime selection, set lifecycle_stage to runtime_enabled, enable live switching, allow paper/dry_run/live, and clear blocked_live_reason. Deep comparison confirms these are the only six source configuration changes. Russell Top50, every other strategy, existing targets and live_continuity remain unchanged.
Regenerate the catalog projections and frontend bundle. Fix CI's reconstruction of the fixed old candidate by reading its original immutable policy blob instead of today's catalog; retain the historical 14-profile freeze assertions and all candidate identity checks. The current catalog has 13 frozen profiles. Add coverage distinguishing the historical policy from the restored Global ETF policy, and correct the account-settings catalog expectation to include Global ETF.
No dependency pins, schemas, execution code, workflows, deployment settings, broker controls or secrets change. No deployment or trading action is performed. Companion allowlist PR: QuantStrategyLab/UsEquityStrategies#713
How verified