Repository navigation
Connect opt-in unified net metrics to historical report CLI - #590
Merged
Merged
Conversation
This was referenced Oct 13, 2026
7 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historical Batch A reports expose legacy account metrics but do not consume the unified net report. Add --include-unified-net-report to the existing historical CLI and pass this explicit, default-off option through its existing report chain.
Each existing book receives twelve report-only B3 metrics from its exact selected net session returns. Per-period win rate, payoff ratio, profit factor and mean return are labeled separately from closed-trade statistics. Legacy risk-free-adjusted annual metrics remain intact; missing matching gross returns or cumulative trial evidence leave cost drag and DSR null/uncomputable. Invalid mode or unavailable twelve-metric capability is refused before private inputs are read.
Production pins, cloud defaults, ranking, fees and old research artifacts are unchanged. A separate immutable QPK b23511cb CI environment requires capability provenance, the actual CLI, hand calculations and zero skips. Default ordinary output is byte-identical; historical reports update only their real source hashes and derived evidence digest when the option is off.
Validation: latest focused 131 passes; latest, production-pin refusal and minimal consumer environments each 34 passes/zero skips; CONTRIBUTING unittest 246 passes, Ruff and actionlint with ShellCheck passed. The local old-pin full run reported 2,467 passes/28 existing skips/460 subtests before the final test network guard was collected; the final guarded module was rerun in all three environments. Final PR CI must verify the complete committed patch before merge. No private research workflow or new strategy trial was run.
Related: QuantRuntimeSettings#632, QuantPlatformKit#659 and #588. B1/B2/B4 remain unfrozen; this engineering change does not implement Bayesian posterior updating or authorize promotion.