Repository navigation
Default-off external cash-flow facts and Modified Dietz returns - #712
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This was referenced Oct 16, 2026
Merged
Retain main history members, coverage, recovery contracts and #718 metadata. Resolve three compatibility conflicts in the authorized five paths; frontend contracts use approved exact C bytes. Propagate Dietz failure reasons without changing asset amounts, calendars or disabled/no-source behavior. All other changes are inherited by the normal draft/main merge. Local only.
Pigbibi
changed the title
Pigbibi
marked this pull request as ready for review
October 17, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept optional
externalFlow.v1through the existing authenticated, account-bound facts receiver and compute native-currency Modified Dietz returns and chained-index drawdown when complete flow windows and real valuations are available. Invalid or incomplete calculations keep returns/drawdown null and propagate the actual reason to the existing performance API and SummaryCards/ReturnsCard.This branch includes a normal merge of main
6a00df408caa7932f09630906a4917e91e430b84. It preserves the merged equity-history and #718 display behavior, the compatible schema union, and the reviewed Kimi type patch. The final EMPTY compatibility adjustment retains the legacy date flag when a member has no real in-range dates; its exact constructed input produces the same complete apply output as49bec3cdf9a3858c4ecf32957cb95eb47fdf233a. This is compatibility preservation, not evidence of a production defect.Validation is bound to head
646e4bf1a7d3d360521bf1c33e4a0f852dac0b56, treea62ca2a6a6ac6450fa8adaaeb9b97eab3ddf20d9:4000015c6683f43b7ee1e546957bf095d059c6952cce070645f20598f51c6429. Kimi types SHA256:dff60c94d602721c530427fd5e8b02ac22f2dd9d7de94a7b314dd547aecb6662.CONSOLE_EXTERNAL_FLOW_ENABLEDremains OFF unless exactlytrue. OFF and ON-with-no-source preserve legacy behavior. Modified Dietz is explicitly approximate; no FX aggregate or manufactured zero flow is introduced. Assets and legacy daily P/L/calendar remain unchanged.No Console/Schwab deployment, collection enablement, real-account call, production backfill, secret/IAM change or new resource is part of this PR integration. Companion Schwab #536 remains unchanged: its collector/report-writer wiring, raw/projection composition, actual pagination/history completeness and source attestation still require separate work. Local/CI validation does not establish real collection or production recovery. Merge is gated on successful CI at the exact reviewed head.