Repository navigation
fix(console): label approximate and unknown return methods - #718
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
October 17, 2026 11:34
Pigbibi
pushed a commit
that referenced
this pull request
Oct 17, 2026
Retain main history members, coverage, recovery contracts and #718 metadata. Resolve three compatibility conflicts in the authorized five paths; frontend contracts use approved exact C bytes. Propagate Dietz failure reasons without changing asset amounts, calendars or disabled/no-source behavior. All other changes are inherited by the normal draft/main merge. Local only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the API identifies a Modified Dietz approximation, the performance summary and return curve currently present it as unqualified TWR. This change displays a shared approximate-method label, handles explicit unknown/null or inconsistent method metadata separately from older responses without those fields, and preserves each currency’s own method, freshness and unavailable reasons. It also updates the method explanation and generated console assets.
The focused regression renders the production React components in both languages against six synthetic API/core fixtures and explicit metadata variants. The existing Validate workflow now runs this regression.
Validation: 100 focused assertions, six affected regression scripts, TypeScript/Vite/size-budget build, and 25 generated-asset integrity checks passed locally. Eight synthetic desktop/narrow screenshots were inspected, including separate USD Dietz and HKD unadjusted curves. No financial values are recalculated in the frontend.
Scope: optional display metadata compatibility with #712. This PR does not merge that draft, change backend return/amount calculations, risk rules or switches, or deploy the Console. Cash-flow source adoption and real-account chain verification remain separate.