Repository navigation
Wire default-off external cash-flow report pipeline - #536
Merged
Merged
Conversation
…xport Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
marked this pull request as ready for review
October 17, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default-off cash-flow draft had three disconnected seams: its collector returned a projection where the report expected a raw snapshot, no runtime caller wrote that snapshot, and the current publisher's upload whitelist removed
externalFlow. This change connects the existing collector to the original report slot and lets the original publisher project and forward it with the same exact opt-in.The existing account-bound client, valuation time, USD checks, positions opt-in, identity checks and single publisher are retained. The runtime hook always leaves source completeness False. No order, risk, allocation, dependency/pin, workflow or production configuration change is included.
SCHWAB_EXTERNAL_FLOW_EXPORT_ENABLEDremains OFF unless exactlytrue; this PR does not enable it.Scope and independent review:
0407949b1b4ebba75fc751682040722aad2876d0: three backend files and four corresponding tests, +614/-1. All other 255 base paths, including deployment workflows and dependencies, are unchanged.198ea40ba4cf254a924b1296708f4a5072b2e0bb.9c6651717973385d84ffd48f76d29b8e9db47438, with parents original draft818252e349eaf64a4c44b35ab238e4f30e8796c3and the accepted source head.264d14612bccdcf14419b210c0cc5d8ec8eedcf1. The three local wiring repairs are independently accepted; no extra final changes are carried from the old draft.Validation at this exact tree:
Known residual acceptance remains explicit:
bfe55791adcd8867790e15dba6fd35304e4093c0drops an emptytransactions: []during report serialization. A synthetic complete empty window becomes incomplete after readback. The nonempty 27 checks do not satisfy strict T04. Missing/null stay unknown; nothing fills them as zero. QPK and its pin are not changed here.This PR is not fully qualified for production collection or cash-flow returns. There has been no live broker/account authentication, collection/backfill, real archive verification, deployment, image build, flag change or real-money operation for this work. Source permissions, currency/time semantics, full history and production arrival remain unverified. The public-writer fix and any adopter pin update require a separate batch; this engineering integration does not enable them.