Skip to content

fix: Restore Global ETF selection for new targets - #1015

Closed
Pigbibi wants to merge 1 commit into
mainfrom
fix/restore-global-etf-selection-20261101
Closed

Pigbibi wants to merge 1 commit into
mainfrom
fix/restore-global-etf-selection-20261101

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #1016. The replacement contains the identical source tree with a commit subject that satisfies commitlint. This draft and its branch are retained without merging or rewriting history.

AI assistance

Prepared with OpenAI Codex (GPT-6). The assistant implemented the patch and ran the checks below.

What changed

Global ETFs is frozen and unavailable for new targets despite the owner's decision to retain its live eligibility. Restore frozen=false, runtime_enabled=true, lifecycle_stage=runtime_enabled, can_switch_live=true, execution modes paper, dry_run, and live, and a null blocked-live reason. Russell Top50 and every other source configuration field remain unchanged.

Regenerate the four console catalog assets from platform-config.json. Test compatible new targets without legacy continuity, aliases, the internal sync handler, and domain restrictions. Synthetic freezes preserve coverage of stale-catalog rejection and risk-reducing continuity; other frozen strategies remain frozen.

Prepared in a separate clone. This draft does not deploy, alter existing targets, change risk or broker gates, update dependency pins, or authorize trading. Companion allowlist draft: QuantStrategyLab/UsEquityStrategies#712

How verified

  • 168 runtime settings tests and 7 frozen-selection tests passed.
  • Frozen-selection/HTTP-handler Node validation passed, including selecting Global ETFs for a registered target without continuity.
  • 7 catalog-release Node tests passed.
  • Config, generated assets, display names, runtime target examples, documentation, and git diff --check passed.
  • Deep comparison confirmed exactly six Global ETF policy fields changed in the source configuration.
  • The broader local Python run encountered the macOS system Bash limitation (mapfile unavailable). Configuration-related expectation failures were corrected and all 175 related tests rerun successfully. The complete local suite is not claimed green.

Draft for review. Leave unmerged and without labels. The risk gate requiring an owner-approved label is intentionally not satisfied by this request.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant