Repository navigation
Conversation
…and inputs - Build income totals without builtin sum() over entity calls (code-health rule) - Gate on is_ssi_eligible so parental resource deeming applies - Count the one-third reduction value once in the couple test - Treat only a co-resident spouse who is not aged, blind or disabled as an ineligible spouse - Drop the TANF-unit and essential-spouse inputs; move excluded income sources to a parameter - Registry placement and comments, SNAP reference title, shorter programs.yaml note, Appendix C-1 page locators - Realistic households and new eligibility, couple and child-support cases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Add Oklahoma state supplementation for 2026PR #10165 (author: hua7450, head SummaryThe PR adds Oklahoma's State Supplemental Payment (SSP), a state-administered and state-funded supplement for aged, blind and disabled people:
The 2026 policy content is right:
Five should-fix items remain:
Critical (must fix)None. Should address1.
2. Four parameter descriptions don't follow the house template.
3. Oklahoma's gross household income for Forms 538-H and 538-S leaves out the new SSP. Its placeholder is still commented out.
4. The couple test counts an ineligible spouse's presumed-value in-kind support.
5. The PR body describes the pre-review design.
Suggestions
Verified correct
Batch checks
Axiom line assessmentInvalid (Should 1).
CI statusAll 26 checks pass (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The 2026 policy is correct: the $40 cap, the $1,034 / $1,532 / $1,571 standards and the $498 allocation match OKDHS Appendix C-1 Sch. VIII, the formula follows OAC 340:15-1-5(c), and all 35 cases check by hand. Five should items (see the comment above): (1) 'axiom: needed' isn't valid for staff and rulespec-us has no OK SSP module, so file a pe-parity issue and add a queued line; (2) four descriptions are off the template; (3) OK 538-H/538-S gross income still has ok_state_supplement commented out (an aged SSI-only homeowner keeps a $200 credit they'd lose once the SSP counts); (4) the couple test counts an ineligible spouse's PMV in-kind support, which 317:35-5-42(l)(12) excludes; (5) the PR body describes handling the last commit removed, and the case count is out of date.
- Count Oklahoma SSP in gross household income for Forms 538-H and 538-S. - Exclude an ineligible spouse's in-kind support and SSI from the couple test, and count an SSI couple's presumed maximum value once. - Treat any spouse living together who is not SSP-eligible as an ineligible spouse (OAC 317:35-5-42(k)(1)). - Uprate the ineligible-spouse standard and child allocation with the SSI cost-of-living adjustment (OAC 340:15-1-4(9)). - Update descriptions, references and documentation, and add tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mirror main's ssi_earned_income exclusion (POMS SI 00820.102) in the per-source rounding loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, David. The fixes are in 50bb3a7, followed by a merge of Should 1 (Axiom line): filed TheAxiomFoundation/rulespec-us#1780 (
The source conflicts below are in a separate comment on that issue, and the axiom line now points to it. Should 2 (descriptions): the four files use your sentences. Should 3 (538-H / 538-S): replaced the placeholder with
Should 4 (spouse's in-kind support): in the couple test, ISM now counts only for SSP-eligible members ((l)(12)).
Should 5 (PR body): rewritten.
Suggestion 1 (history): history stays out of scope, and I didn't widen #8689. Your table did show a problem going forward, though.
Suggestion 2 (Texas rebate copy): #10226 tracks one Suggestion 3 (aged, blind or disabled spouse who isn't eligible): adopted the 317:35-5-42(k)(1) reading. Any spouse living together who isn't SSP-eligible is an ineligible spouse.
Suggestion 4 ( Suggestion 5 (tests):
Suggestion 6 (polish):
Other fixes:
On the merged head, these pass locally: all 402 Oklahoma cases (SSP and tax), the federal SSI suite, and the aggregate list integrity and program registry tests (677 passed, 10 skipped). |
PR Review (round 2): Add Oklahoma state supplementation for 2026PR #10165 (author: hua7450). This round reviews head
SummaryZiming fixed all five round-1 should items. The axiom line now points to rulespec-us#1780, which is open, labelled One new should item comes from the last commit. Excluding pre-tax health premiums from wages is right for federal SSI (POMS SI 00820.102). But Oklahoma's own countable-income rule counts wages "before deductions, such as ... cafeteria plans are subtracted" (317:35-5-42(b)(9)(A)). So Case 21 pins $39.83 where the state rule gives $0. CI is still running: 12 pass, 5 pending and none failed. Round-1 findings status
New findingsCritical (must fix)None. Should address1. The new pre-tax premium exclusion contradicts Oklahoma's own wage definition.
Suggestions1. #1780 relies on (l)(2) but doesn't quote it or list it as a provision.
Verified
Axiom line assessmentValid in form:
CI status12 pass, 5 pending, 0 failed (run 38799749473 on head
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes for 1 new should item; details in the round-2 report above. All five round-1 should items are fixed. rulespec-us#1780 is open and pe-parity labelled, the descriptions are rewritten, ok_ssp is in 538-H/538-S gross income with no double count, the ineligible spouse's ISM is excluded, and the PR body is current. The NH-sibling bug doesn't occur here, and 75 of 75 tests pass. New Should 1: commit 8d2de3b excludes pre-tax health premiums from the state's own wage count. That's right for federal SSI (POMS SI 00820.102), but OAC 317:35-5-42(b)(9)(A) counts wages "before deductions, such as ... cafeteria plans are subtracted". So Case 21 gives 39.83 where the rule gives 0 (1,044.17 ≥ 1,034), and a spouse-wage household gives 40 where the rule gives 0. Fix: revert the SSP wage count to gross wages (SSI unchanged), and update Case 21 and the body. If you keep the exclusion, document it as a conflict on #1780 instead. Five CI jobs were still running when I posted, with none failing.
What and why
Oklahoma's State Supplemental Payment (SSP) was missing from PolicyEngine-US. Add
ok_sspfor 2026 under OAC 340:15-1-4 and 340:15-1-5, the OAC 317:35-5-42 countable income rules and OKDHS Appendix C-1 Schedule VIII. Oklahoma administers and funds the SSP itself (340:15-1-4(1)-(2)), so the payment follows the state's own budget: the standard for the case type less countable income, capped at $40 a month.gov.ssa.uprating(340:15-1-4(9)(A)-(B)), so later years are projections until OKDHS publishes a new C-1.ok_ssp_is_excluded.The SSP is added to the household and SPM benefit totals, SNAP and HUD unearned income, and Oklahoma's gross household income for Forms 538-H and 538-S (68 O.S. 2904(3), 5012; OAC 710:50-15-96(c)).
References
Additional section and page citations are included alongside the parameters and formulas.
Coverage limits
The registry marks Oklahoma as partial, verified for 2026.
Not modeled:
Earlier years use parameter backfilling and are unverified historical estimates; no historical coverage is claimed.
Related:
spm_unit_benefits(such as the Texas rebate's), which this PR leaves unchanged.Test plan
ok_ssp.yaml, 18 inintegration.yaml). They cover:ok_gross_income.yamlcase: an aged homeowner on SSI with gross household income 12,408 and no property tax credit.main: all 402 Oklahoma cases (SSP and tax) and the federal SSI suite pass locally, and the aggregate list integrity and program registry tests pass (677 passed, 10 skipped).ruff formatandgit diff --check.changelog.d/.axiom: OAC 340:15-1-4, 340:15-1-5; OAC 317:35-5-42; OKDHS Appendix C-1 Sch. VIII TheAxiomFoundation/rulespec-us#1780 queued