Repository navigation
Conversation
…nt and parental resources - Apply He-W 616.02's five-year entry rule instead of SSI's 40-quarter test - Pay nothing when the grant is below the $2 minimum (He-W 670.03(a)(4)) - Deem parental resources through the federal pool, which counts stepparents; drop the shared helper - Couple status from the SSI spouse signal; couple grant reduction independent of member order - Derive employment expenses and support deductions from existing variables - Registry placement and comments, SNAP reference title, shorter programs.yaml note, reference locators - Tests for the immigrant rule, minimum grant, stepparent, spouse earnings and couple cases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Review: Add New Hampshire state supplementation for 2026PR #10156 (author: hua7450, head SummaryNew Hampshire's optional state supplement is the state-administered adult cash assistance grant: Old Age Assistance (OAA), Aid to the Needy Blind (ANB) and Aid to the Permanently and Totally Disabled (APTD). The grant is the standard of need minus countable income, and countable income includes the federal SSI payment. So the PR rightly models the whole grant rather than a flat add-on, including state-only grants to people with no SSI. It doesn't model the medical-assistance side.
Most of the 2026 policy content is right:
One critical item:
Three should-fix items:
Critical (must fix)1. Lawful permanent residents with 40 qualifying quarters are kept out during the 5-year wait, which federal law forbids for a state public benefit.
Should address1.
2. Four parameter descriptions are off the house template.
3. Three new eligibility branches have no test.
Suggestions
Verified correct
Batch checks
Axiom line assessmentInvalid (Should 1).
CI statusAll 26 checks pass (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Modeling New Hampshire's full state-administered OAA/ANB/APTD grant is right for NH, all standards match SPA NH-26-0001, the He-W rules are encoded correctly, and all 54 cases check by hand. One critical (details in the comment above): nh_ssp_eligible refuses permanent residents with 40 qualifying quarters during the five-year wait, but 8 U.S.C. 1622(b)(2) makes them eligible for any state public benefit (probe: SSI 994, nh_ssp 0, should be 27). Add the exception with a 0-default quarters input and a test. Three should items: the axiom line ('needed' isn't valid for staff), four off-template descriptions, and untested branches (medical facility, incarceration, non-qualified status).
…tandards and tests - Follow 8 U.S.C. 1622(b)(2): a permanent resident credited with 40 qualifying quarters is exempt from the 5-year wait; document the conflict with AAM 305.13. - Compute the standards of need as the SSI maximum plus the minimum payment level less the standard disregard (He-W 658.03(e), 648.04(b)), so they follow each SSI COLA; correct the three-person standard to the published $1,976. - Add nh_ssp_assistance_group_size and key the standard disregard by group size. - Add cases for untested branches, the one-third reduction, boundaries, mixed and nonapplicant-spouse couples, and the 2027 COLA pass-through; fix descriptions, references, defined_for gates and the changelog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, David. The fixes are in 3972ca1 and a71c7cd, with a merge of Critical 1 (permanent residents with 40 quarters): fixed, and the model now follows 8 U.S.C. 1622(b)(2).
Should 1 (Axiom line): filed TheAxiomFoundation/rulespec-us#1769 (
The axiom line now points to it. Should 2 (descriptions):
Should 3 (untested branches): new Cases 42–44 cover:
Suggestion 1 (frozen standards): fixed for future years; history stays out of scope.
Suggestion 2 (Texas rebate copy): filed #10226 to keep one Suggestion 3 (federal one-third reduction): Cases 45 and 46 pin the household:
Suggestion 4 (APTD in microsimulation): a NOTE in Suggestion 5 (minimum grant ordering): Suggestion 6 (group size):
Suggestion 7 (boundaries and wiring):
Suggestion 8 (polish):
On the merged head, these pass locally: the 73 New Hampshire cases, 243 federal SSI cases, 183 SNAP immigration cases, and the aggregate list integrity and program registry tests (677 passed, 10 skipped). |
PR Review (round 2): Add New Hampshire state supplementation for 2026PR #10156 (author: hua7450). This round reviews head
SummaryZiming fixed the round-1 critical and all three should items, and fixed or documented most suggestions. The 2026 amounts, including the corrected $1,976 three-person standard, check against SR 26-01 and AAM 601 Table A, and all 73 cases pass. The COLA-linked standards follow He-W 658.03(e) and 648.04(b). The group-size refactor (round-1 Suggestion 6) introduced a new critical. People outside New Hampshire now get group size 0, and Separately, round 1 missed 8 U.S.C. 1624, which may support AAM 305.13's rule for permanent residents. That is now a documentation suggestion, not a request to change behavior. Round-1 findings status
New findingsCritical (must fix)1. CI fails: any simulation that mixes an eligible New Hampshire resident with someone from another state raises
Should addressNone. Suggestions1. Round 1 missed 8 U.S.C. 1624, which may support AAM 305.13. Name it in the NOTE and in #1769.
2. The three-person standard could follow the COLA too.
3. The skipped boundary cases don't need tuned incomes.
Verified
Axiom line assessmentValid:
CI status24 pass, 3 fail (
Branch status
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes for 1 critical item; details in the round-2 report above. All round-1 findings are fixed. rulespec-us#1769 is open, pe-parity and ready for the encoder. The COLA-linked standards follow He-W 658.03(e) and 648.04(b), and 73 of 73 tests pass. Critical 1 is the CI failure: nh_ssp_assistance_group_size is NH-gated with an int default of 0, so p.standard_disregard[size] (nh_ssp.py:31, nh_ssp_countable_income.py:68) looks up the nonexistent key 0 for non-NH people. This happens in any simulation that includes an eligible NH resident. It fails 9 tests across the Microsimulation and Rest jobs, breaks national runs, and reproduces locally with NH + MA households. Fix: set default_value = 1 or drop the defined_for (both checked: [27, 0]), and add a two-state YAML case so it stays pinned. Three optional suggestions are in the report (8 U.S.C. 1624, the three-person standard following the COLA, and direct countable-income cases).
What and why
Implements New Hampshire State Supplement Program for researched 2026 coverage, with state-specific eligibility, payment rules, and integration into benefit totals and SNAP/HUD income.
Models the 2026 individual and couple need standards, certified community care, state income disregards, resource limit, rounding and grant reduction. State medical decisions, specialized deductions, care placement and no-SNAP grant reductions require explicit inputs. Blind children include full co-resident parental resource excess; certified exceptions and eighteenth-birthday month treatment require a deemed-resource input. Needy essential-person groups use a certified caregiver income/resource budget. The standards of need follow He-W 658.03(e) and 648.04(b): the SSI maximum for the assistance group plus New Hampshire's minimum payment level less the standard disregard, so they move with each SSI cost-of-living increase. The minimum payment levels ($27 individual, $21 two-person, $89 / $149 / $207 / $207 for community residences, enhanced family care and residential care) match SSA's January 1998 and 2011 tables and every New Hampshire January release from 1998 (SR 97-44) to 2026. The three-person standard is the published $1,976 (SR 26-01), which can't be derived from SSA amounts. Conditional resources, sanctions and grandfathered benefits are not modeled.
Qualified aliens follow He-W 616.02 and 8 U.S.C. 1622(b). AAM 305.13 keeps permanent residents out for 5 years "regardless of work history"; the model follows 8 U.S.C. 1622(b)(2), which makes a permanent resident credited with 40 qualifying quarters eligible for any state public benefit (
snap_alien_qualifying_quarters, default 0). Aid to the Permanently and Totally Disabled readsis_permanently_and_totally_disabled, an input that defaults to false, so microsimulation pays it only where the dataset sets it.Parameter backfilling does not establish verified historical coverage.
Related: #9190; historical backdating remains separate. #10226 tracks the reform copies of
spm_unit_benefits(such as the Texas rebate's), which this PR leaves unchanged.References
Additional section and page citations are included alongside the parameters and formulas.
Test plan
nh_ssp.yaml, 10 inintegration.yaml, 6 innh_ssp_assistance_group_size.yaml, 3 innh_ssp_resources_deemed_from_parents.yaml) pass locally after mergingmain, with the 243 federal SSI cases, the 183 SNAP immigration cases, and the aggregate list integrity and program registry tests (677 passed, 10 skipped).make format, reference/registry checks, andgit diff --check.axiom: He-W 658.03; He-W 648.04; He-W 670.03; SPA NH-26-0001; 8 U.S.C. 1622(b) TheAxiomFoundation/rulespec-us#1769 queued