fix: reject missing wealth columns - #179
Merged
shivamlalakiya merged 2 commits intoSep 6, 2026
Merged
Conversation
4 tasks
Resolves the CONTRIBUTORS.md conflict by keeping both @be-student entries (PhilanthroPy-Project#163 from PR PhilanthroPy-Project#180, PhilanthroPy-Project#156 from this PR).
This was referenced Sep 6, 2026
shivamlalakiya
added a commit
to be-student/PhilanthroPy
that referenced
this pull request
Sep 6, 2026
Resolves the CONTRIBUTORS.md conflict by keeping all three @be-student entries (PhilanthroPy-Project#163 from PR PhilanthroPy-Project#180, PhilanthroPy-Project#156 from PR PhilanthroPy-Project#179, PhilanthroPy-Project#151 from this PR).
2 tasks
shivamlalakiya
added a commit
that referenced
this pull request
Sep 6, 2026
…attempt (#187) Two follow-ups after the #175/#176 duplicate-PR triage: - CONTRIBUTING.md gets a "Claiming an issue" rule (comment before opening a PR, wait for maintainer assignment) so two people never again spend an evening fixing the same four-line bug. The issue-draft template states the same rule inline, so every newly filed good-first-issue carries it without depending on a reader following a link. - @HeaTTap independently identified and fixed the same dead `hasattr(X, "columns")` branch as @Larslllllll, via #175. That PR was closed as subsumed by #179 (which carried the same fix), but @HeaTTap had no CONTRIBUTORS.md line as a result; Lars was already credited via #174. This adds it.
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
An explicit
wealth_colslist that matches no training column now raises an actionableValueErrornaming requested and available columns. Partial matches and automatic detection remain valid. The dead post-validation DataFrame branch is removed, with feature-name behavior covered for frames and arrays.Validation
make ci: 1,951 passed, 25 skipped, 97.53% coverageCloses #156