docs: add the claim-before-PR rule, credit @HeaTTap for the #168 fix attempt - #187
Merged
Merged
Conversation
…attempt Two follow-ups after the #175/#176 duplicate-PR triage: - CONTRIBUTING.md gets a "Claiming an issue" rule (comment before opening a PR, wait for maintainer assignment) so two people never again spend an evening fixing the same four-line bug. The issue-draft template states the same rule inline, so every newly filed good-first-issue carries it without depending on a reader following a link. - @HeaTTap independently identified and fixed the same dead `hasattr(X, "columns")` branch as @Larslllllll, via #175. That PR was closed as subsumed by #179 (which carried the same fix), but @HeaTTap had no CONTRIBUTORS.md line as a result; Lars was already credited via #174. This adds it.
shivamlalakiya
deleted the
docs/claiming-issue-rule-and-heattap-credit
branch
September 6, 2026 20:00
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups after the #175/#176 duplicate-PR triage (now resolved: #175/#176 closed, #168/#156/#163/#151 all closed via #179/#180/#178):
CONTRIBUTING.mdgets a "Claiming an issue" rule: comment on an issue before opening a PR, and wait for a maintainer to assign it. The issue-draft template states the same rule inline.CONTRIBUTORS.mdfor independently identifying and fixing the same dead branch as @Larslllllll (fix: remove dead hasattr branch in WealthPercentileTransformer.fit (#168) #175, subsumed by fix: reject missing wealth columns #179). @Larslllllll was already credited via test: add edge-case tests for WealthPercentileTransformer missing columns (#169) #174; @HeaTTap had no line.Test plan
make cigreen