fix: accept parsed gift dates - #180
Conversation
Resolves the CONTRIBUTORS.md conflict by keeping both @be-student entries (PhilanthroPy-Project#163 from PR PhilanthroPy-Project#180, PhilanthroPy-Project#156 from this PR).
Resolves the CONTRIBUTORS.md conflict by keeping all three @be-student entries (PhilanthroPy-Project#163 from PR PhilanthroPy-Project#180, PhilanthroPy-Project#156 from PR PhilanthroPy-Project#179, PhilanthroPy-Project#151 from this PR).
|
@be-student three merged fixes in one day, and all three were real defects rather than coverage padding. #179 in particular closed a silent no-op: a You clearly read the codebase rather than just the issue text, so I'd rather point you at something open-ended than another labelled issue. #110 is the one unresolved design question in the hospital-fundraising path: index-encounter keying versus the PHI-free bundle contract, which Separately, if anything about getting set up here was annoying, I'd like to hear that too: #188 |
Fixes #163.
Normalizes the gift-date column before scikit-learn validates the mixed-dtype frame, so both strings and
datetime64inputs work. Invalid non-missing dates now raise a column-specific error.Validation:
make ci(1,951 passed, 25 skipped; 97.44% coverage).