Repository navigation
feat: filter v7.0.0 customers at a bank by customer attributes - #2966
Merged
simonredfern merged 8 commits intoNov 10, 2026
Merged
simonredfern merged 8 commits into
simonredfern merged 8 commits into
Conversation
GET /obp/v7.0.0/banks/BANK_ID/customers returns each Customer with its Customer Attributes. Query parameters other than limit, offset and sort_direction filter on attributes: comma-separated values match any of them, different names must all match.
…g of v7.0.0 customers
… validate the filters Only the requested page of matching Customers is loaded, ordered by customer_id; attributes are read in one connector call; reserved OBP query parameters are not taken for attribute names; a filter without a value is refused with OBP-10034; a connector failure fails the request.
…e and dangling attributes of v7.0.0 customers
…served names in any case
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /obp/v7.0.0/banks/BANK_ID/customersis native in v7.0.0 again and returns each Customer with itscustomer_attributes. Any query parameter other thanlimit,offset,sort_direction,from_date,to_dateandsort_by(in any case) and names starting withobp_or_filters by Customer Attribute: a parameter takes several values separated by commas (OBP-API refuses a parameter name given twice), and several parameters must all match, e.g.?organisation_kind=bank_fi,university&country=DE. A filter without a value returns 400 (OBP-10034). Without filters the endpoint behaves like v6.0.0 (ordered by last_ok_date); with filters the matching Customers are ordered by customer_id insort_direction(default descending), only the requested page is loaded, a Customer whose attribute points to a missing Customer is skipped so a page can be shorter thanlimit, and a connector failure fails the request. It needsCanGetCustomersAtOneBankat that bank.CustomersAtOneBankV700Testcovers 13 scenarios (role, unfiltered list, single and comma values, AND across names, duplicate names, paging and ordering, other banks, empty values, reserved names, dangling attributes).Not covered yet: filtering still reads all matching customer ids from the connector before paging, as v4.0.0 does.