Repository navigation
refactor: call OBP-API on v5.1.0 or newer across the app stack - #10
Merged
simonredfern merged 23 commits intoNov 10, 2026
Merged
Conversation
…on OBP-API v5.1.0
…allenge endpoints on OBP-API v5.1.0
…ncatenation or in a constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal, API Manager, Cohort and the shared package now call every OBP-API endpoint that used a version below v5.1.0 on
/obp/v5.1.0/..., so a deployment can disable v1.2.1 to v5.0.0 without breaking the apps; calls already on v5.1.0, v6.0.0 or v7.0.0 are unchanged. Each switched call was checked against the resource-doc catalogs: v5.1.0 serves the same implementation, apart from the product endpoints, which move to the v5.0.0 implementation with an identical schema. Cohort looks members up withGET /obp/v7.0.0/users?username=, which searches all identity providers and takes an exact match; a username held by users of more than one provider gets its own message (member_ambiguous). The changes are grouped by resource, the developer pages and notes show v5.1.0 paths, andpackages/shared/src/lib/server/obp/obpApiVersion.test.tsfails if a call below v5.1.0 is added, including one built without a leading slash, by concatenation or from a version constant. It was verified on a local stack with v1.2.1 to v5.0.0 disabled (Portal and API Manager login through OBP-OIDC, the affected pages, no 404s from OBP-API).Not covered yet: the two Cohort calls to
/obp/v4.0.0/banks/BANK_ID/customers?organisation_kind=stay as they are, listed in that test, until the v7.0.0 attribute filter in OpenBankProject/OBP-API#2966 is released.