Repository navigation
feat(cohort): list organisations from OBP-API v7.0.0 customers filtered by attribute - #12
Merged
simonredfern merged 11 commits intoNov 10, 2026
Conversation
…ering them again OBP-API v7.0.0 already filters the Customers by organisation_kind, so the same check no longer lives in Cohort as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cohort lists its organisations with
GET /obp/v7.0.0/banks/BANK_ID/customers?organisation_kind=bank_fi,university,regulator,partner, which returns each Customer with its attributes, and readslimit=200pages until a page comes back empty, because a page can be shorter than the limit before the end. Cohort shows the Customers OBP-API returns as they are, without filtering them a second time. The organisations page andscripts/seed-demo-data.mjsboth use this, so Cohort no longer calls/obp/v4.0.0, andobpApiVersion.test.tsnow allows no call below v5.1.0 anywhere in the app stack. It needs an OBP-API with the v7.0.0 customer attribute filter (OpenBankProject/OBP-API#2966). It was checked on a local Kubernetes cluster: the organisations page lists the seeded organisations and leaves out a startup Customer and a Customer without a kind, and running the seed script again finds every organisation it created.