Repository navigation
Make snapshot range checksums portable - #198
danielmawhirter wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
|
Observed failure: Windows wheel compilation fails with E0433/E0599 in This one-file PR at Change map
|
Summary
Snapshot range checksums import a Unix-only API, preventing the Windows ingest binary and finished Engine wheel from compiling. Use portable seek/read on each independently opened range file. Preserve checksum order, empty-file CRCs and checked missing/truncated-file errors.
Add an independent CRC oracle over parallel, unaligned ranges crossing the 1 MiB buffer boundary, plus empty, missing, zero-range and short-file controls.
This PR targets
dm-bigquery-test-eligibilityatcf81f2c5. The stack is #196 → #198 → #169. Current head is957f9ef17a2bee7d137f1a27de4b104a2ca50f9a; its tree exactly matches the previous prerequisite treeb0e769f5, and its diff from #196 is only the snapshot checksum file. #197 is closed because main removed the vendored epserde source it classified.Inherited saved-index requirement
Main's #175 removes unused PtrHash remapping and upgrades epserde to 0.13.2/format 2.0. Rebuild existing indexes from source data; do not resume ingestion from an old primary-key-map checkpoint. This compatibility boundary comes from main and applies to this candidate. Frozen 0.8 fixtures now test explicit rejection; they no longer establish old-index readability.
Testing done
957f9ef1, affected snapshot module: 24 passed, zero failures or skips;git diff --checkpasses. Current-head Testing and Coverage succeeds with 50 successful jobs and one expected duration-recording skip, including native Clippy. The packages job passes the installed Engine suite (1,162 passed, 26 skipped), SDK suite (664 passed, 28 skipped) and Core consumers (358 passed, seven skipped).96a65382. That candidate's final platform qualification succeeds: four wheel builders, twelve CPU wheel qualifications and 176 resolver combinations, with 21 successful jobs and two release-only skips. Its Windows MSVC build verifies the finished wheel and passes ten path-safety tests plus the unsupported-profiling test. This is integrated-candidate platform proof; the prerequisite head's own hosted proof is the current Testing run above.The BigQuery test-eligibility correction is inherited from #196. Current-head config/connector CI passes with 1,892 passed, 64 skipped and one expected failure under
KUMO_RUN_GCP_TESTS=0; the historicala1490204restricted-identity failures preceded this corrected base. Current-head public connector CI passes all nine jobs and lint CI passes all eleven.Change map
File-by-file rationale and verification.