Skip to content

Tighten epserde vendored-header exemptions for v1.0.1 - #197

Merged
danielmawhirter merged 1 commit into
releases/v1.0from
dm-epserde-vendor-headers
Nov 4, 2026
Merged

danielmawhirter merged 1 commit into
releases/v1.0from
dm-epserde-vendor-headers

Conversation

@danielmawhirter

@danielmawhirter danielmawhirter commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Kumo Engine v1.0.1 retains patched epserde 0.8 on releases/v1.0. Replace wildcard header-check exemptions with the 42 existing copied file paths so new files require NVIDIA headers. Preserve the manifest’s aggregate license and the release branch’s existing header fixes.

Validation: 23 focused licensing tests pass; the full header check passes for 5,853 tracked candidate files with 101 exclusions; all 12 Python manifests pass license metadata checks. Flake8, isort, and git diff --check pass. The new boundary test fails against the release branch’s wildcard policy.

File-by-file change map.

@copy-pr-bot

copy-pr-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@danielmawhirter
danielmawhirter temporarily deployed to gha-kumo-workflow-tests November 4, 2026 17:37 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@danielmawhirter

danielmawhirter commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author

Change map

Release requirement: retain the vendored epserde header fix for v1.0.1. The release branch already preserves copied headers, but its wildcard exemptions also cover future files. Limit this PR to exact exemptions and regression coverage; the change is complete when copied files pass and owned/new files remain checked.

File Function / scope What changed Why
scripts/license_header_policy.json epserde exclusions Replace seven wildcard patterns with exact paths for the same 42 copied files; preserve existing license declarations. Require headers on future files while retaining upstream attribution.
test/scripts/test_check_license_headers.py test_epserde_vendor_boundary Check exact exemptions, copied-source and manifest licenses, and owned/new-file header enforcement. Prevent exclusions from swallowing future source or tests.

Validation: 23 licensing tests, the full tracked-file header check, 12 manifest checks, flake8, isort, and git diff --check pass. The new test fails against the original release policy.

GPU CI: copy-pr-bot cannot run GPU CI if the latest push occurred while the PR was a draft. Marking it ready alone is insufficient. Signed update 5f1559c9 was pushed after this PR was ready for review to retrigger; its source tree is unchanged. The commit is signed with /home/dmawhirter/.ssh/id_ed25519 and GitHub reports the signature as verified.

@haoweiyu-kumo

Copy link
Copy Markdown
Collaborator

btw, this is not needed after I merge this #175

@danielmawhirter

Copy link
Copy Markdown
Collaborator Author

Superseded by upstream main 48a378d (#175), which removes vendored epserde entirely. The signed update a7c1abb removes this PR’s now-obsolete path exemptions and boundary test; its tree is identical to main. No vendor-header exception or policy change is needed. The remaining focused stack is #198 → #196 → #169; indexes must be rebuilt for the new upstream PK-map format.

@danielmawhirter danielmawhirter changed the title Fix epserde vendored-source header classification Tighten epserde vendored-header exemptions for v1.0.1 Nov 4, 2026
@danielmawhirter
danielmawhirter changed the base branch from main to releases/v1.0 November 4, 2026 22:07
@danielmawhirter
danielmawhirter force-pushed the dm-epserde-vendor-headers branch from a7c1abb to da48ce0 Compare November 4, 2026 22:07
@copy-pr-bot

copy-pr-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@danielmawhirter
danielmawhirter temporarily deployed to gha-kumo-workflow-tests November 4, 2026 22:09 — with GitHub Actions Inactive
@danielmawhirter
danielmawhirter marked this pull request as ready for review November 4, 2026 22:13
@danielmawhirter
danielmawhirter force-pushed the dm-epserde-vendor-headers branch from da48ce0 to dc0e5a6 Compare November 4, 2026 22:31
@danielmawhirter
danielmawhirter temporarily deployed to gha-kumo-workflow-tests November 4, 2026 22:31 — with GitHub Actions Inactive
@danielmawhirter
danielmawhirter merged commit 663b10b into releases/v1.0 Nov 4, 2026
107 of 108 checks passed
@danielmawhirter
danielmawhirter deleted the dm-epserde-vendor-headers branch November 4, 2026 22:58

This branch was previously deployed

1 inactive deployment
gha-kumo-workflow-tests — 5f1559c9 Deployed Nov 4, 2026 by danielmawhirter via import #1533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants