[danielmawhirter]

Summary

Honor KUMO_RUN_GCP_TESTS=0 before BigQuery test credential setup. Jobs that disable GCP tests otherwise fail when ambient ADC exists without the two restricted identity variables. Preserve enabled and unset behavior, including required-identity errors.

This corrects the baseline eligibility failure observed while qualifying DiskGraph #169. The stack is #196 → #198 → #169; this PR targets main and changes only the two eligibility files. Current head is cf81f2c5a31eec8711818d2de39bee3acef28d05, based on main 48a378da. #197 is closed because main removed its vendored-source subject. CI configuration and cloud authentication remain separate concerns.

Inherited saved-index requirement

The prerequisite branch incorporates main 48a378da and its #175 epserde 0.13.2/format 2.0 upgrade. Rebuild existing indexes from source data; do not resume ingestion from an old primary-key-map checkpoint. Frozen 0.8 fixtures now test rejection. This is inherited main behavior, separate from the BigQuery execution guard.

Testing done

• At current head cf81f2c5, pytest -q test/testing/test_bigquery_credentials.py: 18 passed, covering disabled sync/async wrappers, both restricted identities, enabled/unset execution and fail-fast controls. The six disabled-mode cases fail against the original helper.
• Current-head Testing and Coverage succeeds: 50 successful jobs and one expected duration-recording skip. The config/connector shard passes under KUMO_RUN_GCP_TESTS=0: 1,892 passed, 64 skipped and one expected failure. The packages job passes the installed Engine suite (1,162 passed, 26 skipped), SDK suite (664 passed, 28 skipped) and Core consumers (358 passed, seven skipped).
• Current-head public connector CI passes all nine jobs; lint CI passes all eleven, including flake8 and isort. Changed-file flake8, isort --check-only and git diff --check also pass locally.

Change map

File-by-file rationale and verification.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[danielmawhirter]

Observed failure: jobs explicitly setting KUMO_RUN_GCP_TESTS=0 still enter BigQuery credential setup and fail when ambient ADC exists without restricted permission-test identities. The workflow already suppresses GCP authentication in this mode. Skip before setup only for the explicit disabled value; enabled and unset execution retain their original checks.

The stack is #196 → #198 → #169. This PR targets main 48a378da at head cf81f2c5a31eec8711818d2de39bee3acef28d05 and changes exactly the two files below; the portable checksum change belongs to #198. #197 is closed after main removed the copied vendor source. Main's epserde 0.13.2/format 2.0 requires rebuilding existing indexes and rejects old primary-key-map checkpoints. The inherited rebuild boundary is documented in the PR body.

Current-head verification is complete: eighteen focused tests pass; Testing CI has fifty successful jobs and one expected duration-recording skip; all nine public connector jobs and all eleven lint jobs pass. The previously failing config/connector shard now reports 1,892 passed, 64 skipped and one expected failure under the explicit disabled flag. The isolated installed Engine and SDK suites pass 1,162 and 664 tests respectively. Exact run and job links are in the PR body.

Change map

File	Function / scope	What changed	Why
kumo/testing/bigquery.py	withBigQueryCredentials common _setup	Skip before credential setup only for exact KUMO_RUN_GCP_TESTS=0; preserve unset and enabled behavior.	Make the test decorator honor the existing explicit execution gate without changing credential APIs, CI or cloud policy.
test/testing/test_bigquery_credentials.py	Disabled sync/async and enabled/unset controls	Add twelve cases exercising existing ADC, both absent restricted targets, no setup/body calls while disabled, enabled execution and required-target errors.	Six disabled-mode cases fail before the fix; all eighteen focused tests and changed-file flake8/isort pass afterward.

Stopping condition: disabled decorated tests skip without credential access; enabled/unset tests retain existing setup and errors. Live GCP authorization, separate GCS helpers and CI policy remain outside this two-file fix.