Expose generic Compose extension and devcontainer contract - #148
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose a generic Compose extension contract so external app repositories and devcontainers can reuse the NCDD runtime without introducing an app-specific lifecycle.
Changes
dev-workerresponsible only for runtime dimensions, isolation, lifecycle and URLs;APP_ID,APP_SOURCE_DIR, persisted app bindings and setup hooks with a genericNCDD_COMPOSE_OVERRIDE;volumes/nextcloud/apps-extraworkflow fully supported and remove the legacy/deprecation framing;proxy-tests.ymlinto a dedicatedworker-tests.yml;.docker/Dockerfile.php*files instead of enumerating versions;Design boundary
NCDD owns the Nextcloud runtime: PHP, databases, proxy, mail, Redis, worker state and lifecycle.
Consumer repositories own their source layout, application dependencies, setup commands and any project-specific services. A Compose override extends the canonical runtime instead of creating another setup path.
This means NCDD does not need to know which application is being developed and does not restrict a worker to a single app.
Validation
546853e819da58e1b9043171d161cbb21b17a7c4is OpenPGP verified and DCO matches the author.Closes #143