Repository navigation
Use one application workspace per worker - #149
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the arbitrary downstream Compose extension with one optional application workspace per worker.
Each workspace is a directory containing whatever set of Nextcloud apps that worker needs. NCDD mounts the complete directory at
/var/www/html/apps-extraand remains unaware of individual app ids, dependencies or repository layout.This follows up #148 with the smaller contract discussed after merge.
Changes
NCDD_COMPOSE_OVERRIDEwithNCDD_WORKSPACE;.docker/workspace.ymlowned by NCDD instead of accepting consumer-controlled Compose;volumes/nextcloud/apps-extrabehavior when no workspace is provided;.workers/<worker-id>and never delete the external workspace;MARIADB_VERSIONand validate it against.docker/database-services.ymlinstead of hardcoding a version-to-service mapping;Design boundary
A worker represents one isolated Nextcloud development environment.
The caller decides what applications belong in that worker by preparing one directory. It may contain zero, one or dozens of apps, including clones or Git worktrees.
NCDD owns PHP, Nextcloud, databases, proxy, supporting services and disposable worker state. It does not model a primary app and does not expose its Compose topology as a downstream API.
Validation
Commit
b7bc2c9f3ac48bb47c1875001c618d75791600b2is OpenPGP verified and includes a matching DCO sign-off.