Expose a reusable downstream app consumer contract - #147
Closed
vitormattos wants to merge 2 commits into
Closed
vitormattos wants to merge 2 commits into
vitormattos wants to merge 2 commits into
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
Superseded by #148. The original downstream-app contract made the worker aware of a primary app ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a generic downstream-app contract so Nextcloud app repositories can reuse this environment without copying its Compose topology.
Changes
APP_SOURCE,APP_IDand optionalAPP_SETUP_HOOKto the worker lifecycle;/var/www/html/apps-extra/<APP_ID>;www-datauser after Nextcloud is ready;includeadapter for devcontainers instead of duplicating the infrastructure topology;Compatibility
Existing workers that do not set
APP_SOURCEbehave exactly as before.The contract remains generic to Nextcloud app development and contains no LibreSign-specific setup logic.
Validation
Closes #143