Repository navigation
fix(pace-cc): refuse what the key cannot see; dispatch reads the language and depfile rule as the driver does - #1766
Merged
Conversation
…uage and depfile rule as the driver does - Flags naming something the key does not hash are refused by table (UncacheableFlags, each row carrying the reason the launcher prints): -march/-mcpu/-mtune=native (#1688), profiles, plugins, specs files and -B (#1692), and a depfile requested through -Wp,-MD or by -MD/-MMD without -MF, which a hit cannot reproduce (#1689). - -gsplit-dwarf, --coverage, -ftest-coverage, -ftime-trace, -fstack-usage and -save-temps write a file beside the object and join SideArtefacts (#1691). - A <header>.gch gcc would read in place of a header is looked for after the key's preprocess, and such a compile is not cached (#1700). - A driver whose identity probe answered nothing is keyed on its file name, which every version shares; DriverIdentityProbe now says so (IdentityEvidence) and the launcher refuses (#1698). - A manifest over a header expanding __DATE__/__TIME__/__TIMESTAMP__ is not recorded (#1695). - Dispatch takes a GNU driver's language only from selectors before the source (#1697), and writes a dispatched depfile with the build's -MT/-MQ targets and -MP phony rules (#1696). Closes #1688 Closes #1689 Closes #1691 Closes #1692 Closes #1695 Closes #1696 Closes #1697 Closes #1698 Closes #1700 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d clang-tidy wants as a pointer Catch2 reads a case name that opens with '-' as an option, so the -MD case failed to run and test-name-hygiene refused it; it now opens with 'A'. UncacheableFlagReason's find_if result is a pointer on libstdc++, which readability-qualified-auto rejects; core::findIfOrNull answers the same question without naming an iterator. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1NzphJd7AnqGSY9ZLBbS Signed-off-by: Yaraslau Tamashevich <yaraslau.tamashevich@gmail.com>
Yaraslaut
merged commit Nov 14, 2026
28b0d1f
into
fix/windows-dispatch-and-verify
28 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nine audit findings (2026-10-17) from one class: the cache served or stored an object that something outside the key had changed. Each premise was checked against the current tree before it was fixed.
-march/-mcpu/-mtune=native: this machine's CPU-B-MD/-MMDwithout-MF, or through-Wp,-MD-gsplit-dwarf,--coverage,-ftest-coverage,-ftime-trace,-fstack-usage,-save-tempsSideArtefacts<header>.gchgcc reads in place of the header-includeIdentityEvidence::NameOnly; not cached__DATE__/__TIME__used from a header-xafter the source (gcc ignores it), read by dispatch anyway-MT/-MQ/-MPin a dispatched compile's depfileDepFileRulesOfand a multi-targetRenderDepFilewith phony rulesThe refusals are one table,
UncacheableFlags. Each row carries the reason the launcher prints underPACE_VERBOSE. Refusing rather than hashing is deliberate:nativecannot be known from the command line, and hashing a profile or plugin on every compile costs more than the refusal, which is one local compile.Testing
pace-cc-tests: 1165 cases pass. Each refusal has a control that must stay cacheable:-march=x86-64-v3,-g, CMake's-MD -MT -MF, and a leading-x.docs/tools/pace-cc.md, known limitations) and the compile-cache rulebook are updated.Closes #1688
Closes #1689
Closes #1691
Closes #1692
Closes #1695
Closes #1696
Closes #1697
Closes #1698
Closes #1700
🤖 Generated with Claude Code