Repository navigation
fix(storage): a failed mirror read drops L1; archive renames are made durable; a fetch's write-back never overwrites a newer store - #1767
Merged
Conversation
… durable; a fetch's write-back never overwrites a newer store - LayeredStorage: when the L2 write succeeded and its read-back for the L1 mirror did not, the client was told the write failed and L1 kept serving the old value. L2 is canonical: L1 now drops the key and the write reports its success (#1705). - RaftStoreArchiver syncs every directory its renames wrote -- the state directory and the staging directory after the moves, the archive directory after the rename completing it -- through the injected IDurableFiles, degraded rather than refused where a volume cannot sync a directory, as every state file's replace is (#1608). - LocalCache writes a fetched upstream value back with Add, never Set: a STORE made while the fetch was suspended is the newer value and is no longer overwritten (#1706). Each new test was shown to fail with its fix neutered. Closes #1705 Closes #1608 Closes #1706 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ead them A StorageError built field by field (GCC and Clang refuse a designated initializer that omits members), the optional the peek-failing fake answers with read under its own check, and the recording fake's directories behind an accessor. Refs #1705 Refs #1608 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yaraslaut
force-pushed
the
fix/storage-durability
branch
from
November 15, 2026 08:38
88adace to
189b8e1
Compare
GitHub now provisions some ubuntu-24.04 runners on AWS, and those name `us-east-2.ec2.archive.ubuntu.com` in `/etc/apt/apt-mirrors.txt` where an Azure runner of the same image names `azure.archive.ubuntu.com`. That host was on no allowlist row, so the sweep removed `ubuntu.sources`, guard two refused, and every Linux job landing on such a runner died at `Install build tools` (run 43695459864, image 20261111.127.1) while its siblings on Azure went green. The archive's regional mirrors are subdomains of `archive.ubuntu.com`, and which one a runner reaches depends on where it runs, not on anything this repository chose. `AllowedDomainSuffixes` admits any host ending in `.archive.ubuntu.com` -- a domain match, not a substring -- kept apart from `AllowedHosts` because that list is walked unquoted and a `*` there globs. Case 13 pins the AWS layout and fails without the suffix list; case 14 pins that a look-alike (`evilarchive.ubuntu.com`, `archive.ubuntu.com.example.invalid`) is still swept, and fails when the match drops its leading dot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1NzoYifjZBWKpwfN4Qs7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three storage-path fixes, each a value or a rename that did not survive what it should have. Independent of #1763–#1766, so this PR is based on
master.LayeredStorage: the L2 write succeeded but its read-back for the L1 mirror failed. The client was told the write failed, and L1 kept serving the old valueRaftStoreArchiverrenamed the Raft store without syncing any directory, so a power loss could undo a dissolve's archiveIDurableFiles. A volume that cannot sync a directory is degraded, not refused, as every state-file replace isLocalCache: a fetch suspended on the upstream wrote its older value over aSTOREmade meanwhile, undoing the launcher's corrective re-store after a stale hitAdd. A present key is the newer value winning and is not counted as a fill failureTesting
pace-node-tests[archive],[formation],[node][cache]: 347 cases pass.LayeredStorage_test(PaceTest) gains a case with an L2 whose post-writePeekfails. It was compiled locally; the run is CI's.Not in this PR
FilePageStore. Without one, no regression test can fail on purpose, so they go together in a later change.Closes #1705
Closes #1608
Closes #1706
🤖 Generated with Claude Code