Skip to content

fix(pace-cc): a failed store, a stale hit and a failed verify are their own outcomes - #1769

Merged
Yaraslaut merged 2 commits into
fix/windows-dispatch-and-verifyfrom
fix/honest-cache-reports
Nov 14, 2026
Merged

Yaraslaut merged 2 commits into
fix/windows-dispatch-and-verifyfrom
fix/honest-cache-reports

Conversation

@Yaraslaut

Copy link
Copy Markdown
Member

Stacked on #1766. Its base is #1766's branch, so this PR shows only its own commit.

Summary

Points 1–3 of #1707: three cache answers that read as healthy ones in invocations.log, --show-stats and the HTML report.

Was Now Why
MISS after a STORE that was attempted and not taken STORE-FAILED MISS means "compiled and stored", so a cache out of budget read as a cold one
MISS after a hit refused as stale STALE A cache serving stale entries read as an empty one. Only the stale disposition counts: a depfile this machine could not write says nothing against the entry
HIT ("inconclusive") when PACE_VERIFY's fresh compile failed VERIFY-FAILED, new verdict FreshCompileFailed A source the compiler now rejects did not produce the served object. It is said unconditionally, like WRONG OBJECT

Each gets a token, a line in --show-stats and a card in the HTML report, shown only when non-zero, and each counts in the hit rate's denominator. The docs list the three tokens and the new verify line.

Not done here, so #1707 stays open

  • PACE_VERIFY also comparing the replayed depfile and streams, not only the object.
  • The daemon and node counting hits on values the launcher then rejects.

Testing

pace-cc-tests: 1167 cases pass. Every outcome round-trips through the log as itself. A report case asserts each new line, and the verdict-to-outcome mapping and its message are covered.

Refs #1707

🤖 Generated with Claude Code

…ir own outcomes

Three cache answers read as healthy ones (#1707):
- a STORE that was attempted and not taken was logged MISS, which means "compiled and
  stored"; it is now STORE-FAILED;
- a hit refused as stale (a replayed dependency gone, a depfile the value lacks) was logged as
  a cold MISS; it is now STALE -- and only that disposition, not a depfile this machine could
  not write, which says nothing against the entry;
- PACE_VERIFY's fresh compile FAILING was "inconclusive" and tallied as a HIT; it is now its own
  verdict (FreshCompileFailed) and outcome (VERIFY-FAILED), said unconditionally like WRONG
  OBJECT.

Each has its token in the log, its line in --show-stats and its card in the HTML report,
shown only when non-zero, and counts in the hit rate's denominator.

Not done here: verify comparing the replayed depfile and streams, and the daemon/node counting
hits the launcher rejects.

Refs #1707

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Yaraslaut Yaraslaut added type/bug Behaves incorrectly against its stated contract area/compile-cache CompileCache/, the 0xFC wire, the executor, PathCanon area/launcher apps/fastcache-cc/ - the compiler launcher and its cache key area/observability Metrics/, logging, stats and scrape surfaces labels Nov 12, 2026
@github-actions github-actions Bot removed area/compile-cache CompileCache/, the 0xFC wire, the executor, PathCanon area/observability Metrics/, logging, stats and scrape surfaces labels Nov 12, 2026
Base automatically changed from fix/cache-key-inputs to fix/windows-dispatch-and-verify November 14, 2026 20:14
@Yaraslaut
Yaraslaut merged commit 28b0d1f into fix/windows-dispatch-and-verify Nov 14, 2026
26 of 33 checks passed
@Yaraslaut
Yaraslaut deleted the fix/honest-cache-reports branch November 14, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/launcher apps/fastcache-cc/ - the compiler launcher and its cache key type/bug Behaves incorrectly against its stated contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant