Repository navigation
fix(pace-cc): a failed store, a stale hit and a failed verify are their own outcomes - #1769
Merged
Yaraslaut merged 2 commits intoNov 14, 2026
Merged
Conversation
…ir own outcomes Three cache answers read as healthy ones (#1707): - a STORE that was attempted and not taken was logged MISS, which means "compiled and stored"; it is now STORE-FAILED; - a hit refused as stale (a replayed dependency gone, a depfile the value lacks) was logged as a cold MISS; it is now STALE -- and only that disposition, not a depfile this machine could not write, which says nothing against the entry; - PACE_VERIFY's fresh compile FAILING was "inconclusive" and tallied as a HIT; it is now its own verdict (FreshCompileFailed) and outcome (VERIFY-FAILED), said unconditionally like WRONG OBJECT. Each has its token in the log, its line in --show-stats and its card in the HTML report, shown only when non-zero, and counts in the hit rate's denominator. Not done here: verify comparing the replayed depfile and streams, and the daemon/node counting hits the launcher rejects. Refs #1707 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onest-cache-reports
Base automatically changed from
fix/cache-key-inputs
to
fix/windows-dispatch-and-verify
November 14, 2026 20:14
Yaraslaut
merged commit Nov 14, 2026
28b0d1f
into
fix/windows-dispatch-and-verify
26 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points 1–3 of #1707: three cache answers that read as healthy ones in
invocations.log,--show-statsand the HTML report.MISSafter a STORE that was attempted and not takenSTORE-FAILEDMISSmeans "compiled and stored", so a cache out of budget read as a cold oneMISSafter a hit refused as staleSTALEHIT("inconclusive") whenPACE_VERIFY's fresh compile failedVERIFY-FAILED, new verdictFreshCompileFailedWRONG OBJECTEach gets a token, a line in
--show-statsand a card in the HTML report, shown only when non-zero, and each counts in the hit rate's denominator. The docs list the three tokens and the new verify line.Not done here, so #1707 stays open
PACE_VERIFYalso comparing the replayed depfile and streams, not only the object.Testing
pace-cc-tests: 1167 cases pass. Every outcome round-trips through the log as itself. A report case asserts each new line, and the verdict-to-outcome mapping and its message are covered.Refs #1707
🤖 Generated with Claude Code