Repository navigation
docs(foundation): fifth whole-repo pass over foundation, toolkit, dumpkit, interface and utilities (#1103) - #2157
Merged
Merged
Conversation
…pkit, interface and utilities (#1103) - engines: the name= class-keyword collision holds below 3.11, not on 3.10 alone; _pcap_backend does import pcapkit.corekit.infoclass; PyShark 3.13 is inferred, not measured; upstream file:line anchors become names; unsupported_reason() is consulted by engine selection, not run() alone. - reassembly: TCP pseudo-code matches FIN cutting the hole list and the sentinel hole; IP departures name the fixed timeout; IPv6 and DF frames are not submitted for every frame; examples import from the submodules. - traceflow/toolkit: labels come from the opening packet; the link type of a PCAP-NG packet is its interface's, not a global header's. - registry: meth is a method name or a (parser, constructor) pair, not a callable; register_dumper accepts any dictdumper Dumper subclass. - compat, config, dumpkit, utilities: stale version range, unresolvable DictDumper reference, "dumper class itself", missing config/datetime. Prose only; AST guard clean; docs, conventions and slice tests pass.
JarryShaw
force-pushed
the
docs/1103-r5-foundation
branch
from
October 25, 2026 05:04
3cd45ca to
b6e3ab3
Compare
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
This was referenced Oct 25, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the change (prose only; narrow selections below)What is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103, round 5. This is the foundation, toolkit, dumpkit, interface and utilities slice, on
mainat4c3d30163. It changes prose only: with docstrings stripped, the AST is identical on all 25 changed.pyfiles.name=class-keyword collision affects every Python below 3.11, not only 3.10. Measured on 3.8.20, 3.9.25, 3.10.21 and 3.11.15._pcap_backenddoes importpcapkit.corekit.infoclass.unsupported_reason()also runs at construction.PCAP_CT.closekeys on_handle.pcapmodule since fix(foundation): the pypcap engine raises a pcap loader's OSError instead of falling back as pcap_ct does #2132.tcp.rstpseudo-code is updated for fix(reassembly): TCP completion from per-buffer gaps, mod-2**32 sequence numbers, FIN waits for reordered data #1375: FIN cuts the hole list, the hole below a missed handshake is shown, and the hole update continues across holes.Completion.PARTIALno longer counts a FIN as a teardown.methwording in all 15register_*wrappers inregistry/protocols.py. It is a method name or a(parser, constructor)pair, as in docs(protocols): fifth whole-repo pass over link and transport protocols (#1103) #2152, docs(protocols): fifth whole-repo pass over application, misc and the protocol base (#1103) #2154 and docs(protocols): fifth whole-repo pass over internet (#1103) #2155.register_dumperchecksdictdumper.dumper.Dumper.__del__example is corrected.utilitiesdocstring now coversconfigand timestamp conversion.tests/project/test_docs_*and the conventions test: 94 passed.tests/foundation/{engines,registry},tests/utilitiesand the contracts: 393 passed.