Repository navigation
ci: cite pinned third-party code by name, not line (#1103) - #2196
Merged
Merged
Conversation
Problem: comments in cron-conda.yml, experimental.yml, python-compatibility.yml, MANIFEST.in and pyproject.toml cited pinned third-party sources as path:line, against #1103's anchor-by-name ruling. pyproject's xdist/remote.py:146-147 was already off at the 3.6.x it names: those were 3.8.0's line numbers. Fix: each citation names the function, method or table holding the cited lines, read from the source at its pin; the pin stays in the prose. Test: comment-only; no test pins the old form. actionlint is clean and the tests/project files that read these files pass.
JarryShaw
added
docs
Owner
Author
|
Review: GOOD TO GO at |
JarryShaw
added
review: good-to-go
Owner
Author
|
Ready to merge at
|
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— CI or workflow configurationDescription
Part of #1103, ruling 4: line citations into pinned third-party sources name the function instead, as in-repo anchors do.
cron-conda.yml,experimental.yml,python-compatibility.yml,MANIFEST.inandpyproject.toml.ActionCommand.TryParseV2,StepsRunner.RunStepAsync,sdist._add_defaults_standards,WorkerInteractor.pytest_sessionfinish. Each version or commit pin is kept.xdist/remote.py:146-147inpyproject.tomlwas already off for the 3.6.x versions it named. The method name holds across them.tests/projectfiles that read these files pass.pyshark.py'scapture.py:183citation, which docs(foundation): fifth whole-repo pass over foundation, toolkit, dumpkit, interface and utilities (#1103) #2157 already renames.tests/docstrings.file:lineanchors outside the ruling's scope.