Skip to content

docs(docs): fifth whole-repo pass over the non-API docs, with issue/PR roles (#1103) - #2161

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1103-r5-docs
Oct 25, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1103-r5-docs

Conversation

@JarryShaw

@JarryShaw JarryShaw commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

What is the purpose of your pull request?

  • docs — documentation only

Description

Part of #1103 round 5. This is the non-API docs slice, and it also converts issue/PR reference syntax across the repo, as the owner asked on #1103. Base is main 4c3d30163.

@JarryShaw JarryShaw added docs Pull requests that change documentation only (docs: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 25, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

GOOD TO GO at 3dcd2f3f1 (Sonnet review).

  • Roles: all 66 distinct numbers added in the diff were checked with the API, and every role matches. The four PRs (2023, 2037, 2038, 2050) use :pr:.
  • Placement: every changed .py line is a docstring or a #: comment. No conversion landed in a plain # comment, YAML, a test or a code block.
  • Check test: it fails on main and passes here. ScannerTests covers the exclusions: literals, code blocks, comments, Discussions and other-repo links, doctests. All 8 allowlist entries have true reasons, each one a real pin in another test, and a stale-entry test keeps each entry honest. It sets __tier__ = 'LATEST'.
  • Count corrected: the PR body said 142 violations on main. I re-ran the check on a clean main tree: it finds 131 beyond the 8 allowlisted entries, 139 in all. The body now says so.
  • Prose claims:
  • Checks: the AST guard is OK on all 10 pcapkit/ files. 46 test files: 633 passed.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 25, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 91.55% (unit tier, Python 3.15, 3dcd2f3f1, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 4 20 2 95.16%
pcapkit/const 19599 880 2618 866 92.12%
pcapkit/corekit 2589 75 816 37 96.48%
pcapkit/dumpkit 282 3 102 3 98.44%
pcapkit/foundation 2971 23 1036 25 98.80%
pcapkit/interface 138 4 52 3 96.32%
pcapkit/protocols 17418 219 4574 185 98.14%
pcapkit/toolkit 869 36 298 10 95.20%
pcapkit/utilities 504 7 146 5 98.15%
pcapkit/vendor 4432 1988 1018 167 51.87%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw

Copy link
Copy Markdown
Owner Author

Ready to merge at 3dcd2f3f1.

  • Review: Sonnet GOOD TO GO. All 66 distinct role numbers were checked against the API, and every allowlist entry is a real pin in another test.
  • CI: 61 CheckRuns passed, 0 failed, 0 pending. Required checks passed is SUCCESS, and the KTLO legs show no warnings.
  • Ordering: I merged this PR into main and ran tests/project plus the root modules under the plain unittest ordering leg: 2297 tests, with the new check included, 0 failures, 0 errors.
  • Merge order: this PR conflicts with docs(foundation): fifth whole-repo pass over foundation, toolkit, dumpkit, interface and utilities (#1103) #2157 in pcapkit/foundation/engines/pcapng.py; a test merge found it. Whichever of the two merges second needs a rebase, and I'll do that as soon as the first one lands.

…R roles (#1103)

- Cite issues and pull requests by :issue:/:pr: in rendered text: the
  hand-written GitHub links in workflows.rst, releasing.rst and pep.rst,
  the bare #NNN in workflows.rst, and the #NNN in pcapkit docstrings and
  #: comments. #2050, linked as an issue, is a pull request.
- Add tests/project/test_docs_issue_pr_roles_1103_unit.py, which fails on
  a hand-written link or bare #NNN in .rst pages, docstrings and #:
  comments; its allowlist holds only the references other tests pin.
- Record the rule on the documentation conventions page.
- Name the external action functions releasing.rst and workflows.rst cited
  by line, where no test pins the line.
- Fix stale claims: the shared changelog pull request has merged, the
  Windows leg runs leg_summary.py and pip_install.py, Lint expects pylint's
  import-error rather than tracking a count, pypcapfile fails from 3.12 up
  rather than working only on 3.10 and 3.11, cryptography in the all extra
  is no pure-Python wheel; drop "today", "this change" and "current".

Docs build: no warnings, and the same 116 under -n as origin/main.
@JarryShaw

Copy link
Copy Markdown
Owner Author

Rebased onto main after #2157 merged: 3dcd2f3f1 → ac32f4281.

The patch changed in that hunk, so CI runs again. A short delta check is running.

@JarryShaw JarryShaw added review: running A cross-review is in flight against the current head - no verdict yet and removed review: good-to-go Cross-review at the current head says ready; CI state is separate labels Oct 25, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Review: GOOD TO GO at ac32f4281 (Sonnet): rebase check: range-diff differs only in the merged _block_name hunk, the "two counts agree" claim matches the per-kind whole-file counter, and the roles, engines and docstring-contract tests pass.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 25, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Ready to merge at ac32f4281. Part of #1103 (round 5).

  • Review: Sonnet GOOD TO GO.
  • CI: Required checks passed SUCCESS, 0 failed. Still open: the board's Sync Status.
  • KTLO: 12 legs, no warnings.
  • Ordering: project leg merged into main: 2299 tests, 0 failures.

@JarryShaw
JarryShaw merged commit df1f735 into main Oct 25, 2026
64 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 25, 2026
@JarryShaw
JarryShaw deleted the docs/1103-r5-docs branch October 25, 2026 17:45
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 25, 2026
@JarryShaw JarryShaw added this to the PyPCAPKit v1.5 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant