feat(ci): add verification continuation core and 192 regressions - #2863
Conversation
Import immutable input fingerprints, signed evidence verification, additive continuation planning, DAG/sharding and audit primitives. Wire 192 local regressions through the existing Smart CI self-test discovery. Observation only; no selection, settings or required-context changes. Refs #2326, #2329, #2336
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9641988902
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Independent review and single fix-round checkpoint Reviewed this slice with an independent Terra reader, then reviewed only the blocking fix diff. Current head: 6254bbf. The integrated final tree is byte-identical to independently reviewed 636a17329e5a480d702fcf1a9585cf279bbf60fb after preserving each original stack branch and propagating fixes with merge commits. Blocking changes: prohibit Git lazy fetch/protocol execution in immutable readers; use independently trusted self-contained export verification; repair Windows CRLF and privilege-free symlink fixtures. Slice-specific changes remain visible in this PR diff. No result-reuse activation or settings changes. Validation: cumulative Windows control command node --test scripts/ci/smart-ci/*.test.mjs passed 509/509, no failures/skips/cancellations. Independent fix checks: core/repository 110/110; export/workflow 11/11. node scripts/check-doc-links.mjs passed, 683 Markdown files and zero broken relative links. These are additive; hosted CI at the current head/base is still required. Nonblocking findings are tracked once on #2336: #2336 (comment) . Review budget: one original pass and one scoped fix verification, complete. Original E2E/nightly-map findings were already corrected in the previous authored heads and remain covered by the green control tests. The maintainer's current local request explicitly includes finishing and merging this CI work. Parent-first merge order remains #2863, #2864, #2865, #2867, #2868, #2869, #2871; children are retargeted only after parents land, with moved-base requalification. No branch deletion while it is a stack base. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6254bbf650
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Scope
First slice of the maintainer-requested Smart CI Continuation implementation. Adds a dependency-free Node library under
scripts/ci/smart-ci/continuation/with immutable Git input snapshots, transitive task contracts, signed evidence verification, additive continuation planning, dependency-aware scheduling, affinity-preserving sharding and full-oracle audit primitives.Nested tests are explicitly imported by
scripts/ci/smart-ci/continuation.test.mjs, so the existing Smart CI Self-Test context executes them without adding another permanent test workflow. Detailed engineering/trust/rollout documentation is indocs/ci/continuation/README.md, linked from the module README.Boundaries
assertProducerrequires genuinely authenticated collector facts. A JSON artifact claimingtrusted: trueis not production provenance.Validation
Base:
6c51b09bcdcefbc7a852a7047aa9ab8ee5eb10b7.Head:
9641988902b138862489153a58a3d2fb359a3e8b.node --test scripts/ci/smart-ci/continuation.test.mjs: 192 passed, 0 failed/skipped/cancelled, Node 22.16.0 / Linux / Git 2.47.3. Includes real temporary Git object tests and ephemeral Ed25519 signing/forgery regressions. Original complete bundle baseline separately passed 223/223; its adapter/staging tests belong to the next slices.The execution environment could not clone GitHub (DNS unavailable); repository files were read and commits created through the GitHub connector. The full existing Taskdeck control/governance/product suites, Windows and configured Node 24.13.1 have NOT been run locally. Exact-head hosted checks and an independent fresh-context review remain required. No independent-review claim is made.
Review / rollout
R4: park for maintainer + independent review under SC-10; do not auto-merge. This is the first parent of the forthcoming narrow stack; merge parents first and retarget children only after the parent actually lands. Canonical STATUS/MASTERPLAN/OUTSTANDING_TASKS are left to their current coordinator. Human visibility/spend/protection/runner/signing decisions remain untouched.
Rollback: revert the new module, test bridge and scoped documentation; no configuration rollback is needed.
Refs #2326, #2329, #2336. Coordination claim: #2336 (comment 5610534868).